Block Supports: Backport update from Gutenberg #5252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See WordPress/gutenberg#54075 Refactors block supports to use a single Tag Processor instance and to only send a single class at a time to `add_class()`.
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR, changes LGTM. Any reason this is still in draft? I assume we want it committed before Beta 1 tomorrow.
Are you able to open a Trac ticket for this? GH PRs are only for code review.
Member
Author
not sure; I probably didn't have time at the end of the day to create the Trac ticket and so left it as a draft. created that now. |
tellthemachines
approved these changes
Sep 26, 2023
Contributor
|
Committed in r56698. |
2 tasks
This was referenced Sep 29, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: #59443
See WordPress/gutenberg#54075
Refactors block supports to use a single Tag Processor instance and to only send a single class at a time to
add_class().