HTML API: Update code style so it passes when backported into Gutenberg #4360
Conversation
dmsnell
changed the title
- Support a few extra invalid comment syntaxes. WordPress/wordpress-develop#4256 - Invalidate bookmarks which have been eliminated by enqueued changes. WordPress/wordpress-develop#4116 - Expose whether the currently-matched tag has the self-closing flag. WordPress/wordpress-develop#4266 - Avoid double-writing an attribute value if given case-variations of the name. WordPress/wordpress-develop#4337 - Linting updates from WordPress/wordpress-develop#4360.
|
@hellofromtonya this apparently was fine in Core but in Gutenberg it was rejected. I'm not sure why or what happened, as the line in question was called out in review as a surprise that Core's linting didn't catch it. To the best of my recollection I made this change and submitted it only to find the Core linting rejected it, but maybe I messed up when I did that check, because it passes now. Somewhere in here our linters don't agree, and I figured you might be the person to notify about it. |
- Support a few extra invalid comment syntaxes. WordPress/wordpress-develop#4256 - Invalidate bookmarks which have been eliminated by enqueued changes. WordPress/wordpress-develop#4116 - Expose whether the currently-matched tag has the self-closing flag. WordPress/wordpress-develop#4266 - Avoid double-writing an attribute value if given case-variations of the name. WordPress/wordpress-develop#4337 - Linting updates from WordPress/wordpress-develop#4360. - Avoid losing previous updates in certain cases when seeking earlier in a document. WordPress/wordpress-develop#4345
|
I wonder how the previous version of that file (before your patch) could possibly pass the Core CI checks? When I test this in my local environment, I get linter errors. |
|
sounds like a good question @anton-vlasenko 🤷♂️ |
|
@anton-vlasenko @dmsnell The linter throws a warning rather than an error. In WP-Dev, I believe the tests directory action fails on both warnings and errors, but the src directory only fails on errors. I guess the GB repo fails for both warnings and errors too. Edit: Slowly src is getting closer to following the WP CS, I imagine failures on warnings will be enabled once the project is complete |
4 participants
Trac ticket #58170-trac
During the attempted merge of WordPress/gutenberg#49966 the PHP linting rule rejected the PR, even though it's a direct copy from Core.
In this PR we're adding spacing so that we can merge the "blessed" PR without creating conflicts between the two repositories.