Run template-part registration after all other blocks #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 5, 2022 13:52
Prioity 22 was chosen because register_legacy_post_comments_block is priority 21 and this should be called afterwards
This gives more breathing room for blocks that want to register themselves in a different order
ockham
force-pushed
the
try/reprioritizing-block-registration-for-template-part-styles
branch
from
3da02d0 to
f4f1bce
Compare
Contributor
|
Rebased. |
ockham
reviewed
Oct 5, 2022
Comment on lines
+252
to
+256
| /* | ||
| * This block relies on generated styles from previously registered blocks, so | ||
| * it should be registered last. | ||
| */ | ||
| add_action( 'init', 'register_block_core_template_part', 29 ); |
Contributor
There was a problem hiding this comment.
Note that we'd need to make this change to the corresponding file in Gutenberg, since Core's build process uses the files from the @wordpress/block-library package as its source of truth for dynamic blocks' PHP code and overwrites any changes we make here 😬
(I think that's also the reason for the test failures we're seeing in CI.)
Contributor
|
I'll change the Trac ticket linked in the PR desc to https://core.trac.wordpress.org/ticket/56736, since this PR would solve that, and the previously linked ticket (https://core.trac.wordpress.org/ticket/56644) has now been fixed. |
Author
|
Closing this out. Both related trac tickets have been solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another (partial) alternative to #3352, #3359, and #3373.
This adjusts the priorities of block registration so that the
core/template-partblock is registered last. This means that all blocks (exceptcore/template-part) will be registered before the metadata formget_blocks_metadatais called for the first time.It currently has the problem that the block metadata for the
core/template-partblock itself won't be included, but that may be fixed with the combination of cache invalidation from #3373 if we can guarantee thatregister_block_core_template_partnever unregisters any blocks.I upped the
WP_Block_Supports::initpriority value to make room for blocks likecore/post-commentsto be registered after the rest of the core blocks, but before thecore/template-partregistration.Trac ticket: https://core.trac.wordpress.org/ticket/56736
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.