Interactivity API: Fix data-wp-bind to continue processing valid directives after encountering invalid ones
#10746
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a bug in the
data_wp_bind_processormethod where areturnstatement inside aforeachloop was causing the function to exit entirely when encountering a bind directive with an empty suffix or a unique ID.Why
When an element has multiple
data-wp-binddirectives, such as:The first directive (
data-wp-bindwith no suffix) is invalid and should be skipped. However, thereturnstatement was causing the entire function to exit, preventing the validdata-wp-bind--iddirective from being processed.How
Changed
returntocontinueso that invalid entries are skipped while valid entries continue to be processed.Trac ticket: https://core.trac.wordpress.org/ticket/64518
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.