Skip to content

Block Bindings: Allow filtering attributes that are replaced in markup #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ockham wants to merge 4 commits into
base: trunk
Choose a base branch
from
+37 −5
Draft

Block Bindings: Allow filtering attributes that are replaced in markup #10739

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
763bcc2
Block Bindings: Introduce $attribute var in replace_html
ockham Jan 15, 2026
f6035e2
Block Bindings: Allow filtering attributes that are replaced in markup
ockham Jan 15, 2026
8306e22
Add explanatory comment
ockham Jan 15, 2026
97cfc85
Add newline
ockham Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions src/wp-includes/class-wp-block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,19 +372,51 @@
*/
private function replace_html( string $block_content, string $attribute_name, $source_value ) {
$block_type = $this->block_type;
if ( ! isset( $block_type->attributes[ $attribute_name ]['source'] ) ) {

if ( ! isset( $block_type->attributes[ $attribute_name ] ) ) {
return $block_content;
}
$attribute = $block_type->attributes[ $attribute_name ];

/**
* Modify an attribute's properties (for the purposes of being replaced in the block markup).
*
* By default, Block Bindings will replace sourced attributes in the markup with
* the value from the source. However, some blocks persist attribute values explicitly
* and still duplicate them in the markup. In those cases, this filter allows marking
* them as "pseudo-sourced", so that they will also be replaced with the bound value.
*
* @since 7.0.0
*
* @example function( $attribute, $attribute_name, $block_name ) {
* if ( 'core/cover' === $block_name && 'url' === $attribute_name ) {
* $attribute['source'] = 'attribute';

Check failure on line 393 in src/wp-includes/class-wp-block.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Spaces must be used for mid-line alignment; tabs are not allowed
* $attribute['selector'] = 'img';

Check failure on line 394 in src/wp-includes/class-wp-block.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Spaces must be used for mid-line alignment; tabs are not allowed
* $attribute['attribute'] = 'src';

Check failure on line 395 in src/wp-includes/class-wp-block.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Spaces must be used for mid-line alignment; tabs are not allowed
* }
* return $attribute;
* }
*
* @param array $attribute The attribute properties.
* @param string $attribute_name The attribute name.
* @param string $block_name The block name.
* @return array The modified attribute properties.
*/
$attribute = apply_filters( 'block_bindings_attribute_replaced_in_markup', $attribute, $attribute_name, $this->name );

if ( ! isset( $attribute['source'] ) ) {
return $block_content;
}

// Depending on the attribute source, the processing will be different.
switch ( $block_type->attributes[ $attribute_name ]['source'] ) {
switch ( $attribute['source'] ) {
case 'html':
case 'rich-text':
$block_reader = self::get_block_bindings_processor( $block_content );

// TODO: Support for CSS selectors whenever they are ready in the HTML API.
// In the meantime, support comma-separated selectors by exploding them into an array.
$selectors = explode( ',', $block_type->attributes[ $attribute_name ]['selector'] );
$selectors = explode( ',', $attribute['selector'] );
// Add a bookmark to the first tag to be able to iterate over the selectors.
$block_reader->next_tag();
$block_reader->set_bookmark( 'iterate-selectors' );
Expand Down Expand Up @@ -412,12 +444,12 @@
if ( ! $amended_content->next_tag(
array(
// TODO: build the query from CSS selector.
'tag_name' => $block_type->attributes[ $attribute_name ]['selector'],
'tag_name' => $attribute['selector'],
)
) ) {
return $block_content;
}
$amended_content->set_attribute( $block_type->attributes[ $attribute_name ]['attribute'], $source_value );
$amended_content->set_attribute( $attribute['attribute'], $source_value );
return $amended_content->get_updated_html();

default:
Expand Down
Loading