Persist existing translations when introducing new helper text in emails #745
+36
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Dec 22, 2025
| /** | ||
| * Get the client IP address for the current request. | ||
| * | ||
| * Note that the IP address is used only for information purposes |
Collaborator
Author
There was a problem hiding this comment.
Explain the expected setup for this and known limitations.
providers/class-two-factor-email.php
Outdated
| ), | ||
| $token, | ||
| /* translators: %1$s: token */ | ||
| __( 'Enter %1$s to log in.', 'two-factor' ), |
Collaborator
Author
There was a problem hiding this comment.
Keep this string as it was to ensure that the existing translations keep working.
| */ | ||
| public function pre_process_authentication( $user ) { | ||
| if ( isset( $user->ID ) && isset( $_REQUEST[ self::INPUT_NAME_RESEND_CODE ] ) ) { | ||
| if ( isset( $user->ID ) && isset( $_REQUEST[ self::INPUT_NAME_RESEND_CODE ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- non-distructive option that relies on user state. |
Collaborator
Author
There was a problem hiding this comment.
Addressed the rest of PHPCS warnings for the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Keep the existing
Enter %1$s to log in.as standalone string to ensure it works with existing translations. Add the new helper text in own lineDidn't expect this? A user from %1$s has successfully authenticated as %2$s. If this wasn't you, please change your password..Why?
Follow-up to #728.
How?
Testing Instructions
Screenshots or screencast
This now keeps the existing translations for the main sentence:
Changelog Entry