Fix block crash in pattern creator #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
fix/crash-block
branch
from
5acd2ba to
ac2d856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://core.trac.wordpress.org/ticket/64309#comment:3
Props @amitdholiya
I'm not sure how long this issue has been occurring, but it seems to cause blocks to crash when adding or selecting them in the pattern creator.
After investigating, I found that the hook for pattern overrides is affecting this. The underlying issue is likely on the Gutenberg side, but since the pattern editor isn't available in the pattern creator in the first place, let's disable the hook itself for now.
Screenshots
How to test the changes in this Pull Request: