Block visibility: render blocks when hidden at all viewports (and other changes) #74679
+48
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistency and update test case for two breakpoints. Removed redundant check for hidden blocks on all breakpoints.
…ts" to "viewport sizes" for clarity, and adjust related test cases accordingly. This enhances consistency in the codebase.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
changed the title
ramonjd
added
[Type] Code Quality
12 tasks
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
Jan 16, 2026
ramonjd
commented
Jan 16, 2026
| // translators: %s: The shortcut key to access the List View. | ||
| __( | ||
| 'Block visibility settings saved. You can access them via the List View (%s).' | ||
| 'Block visibility settings updated. You can access them via the List View (%s).' |
Member
Author
There was a problem hiding this comment.
Slipped this one in here 😄
Was mentioned that "saved" isn't quite right since nothing is saved until the post is saved.
ramonjd
requested review from
aaronrobertshaw,
andrewserong,
talldan and
tellthemachines
ramonjd
removed
the
[Type] Code Quality
|
Size Change: -1 B (0%) Total Size: 3.09 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jan 16, 2026
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! Feel free to ignore my comment about the breakpoint size, it doesn't really matter. I don't love that we need that final unused breakpoint but haven't any better ideas for now 😄
Thanks for adding the clarifying comment anyway!
| * Note: the last item in the $viewport_sizes array does not technically require a size, | ||
| * as the last item's media query is calculated using `width > previous size`. | ||
| * It's included for consistency and as a record of the "official" breakpoint size. | ||
| */ |
Contributor
There was a problem hiding this comment.
Very minor point given this isn't used, but I wonder if it would be better to use $break-xlarge or even $break-wide value here because 960 is tiny as a max size for desktop.
Member
Author
There was a problem hiding this comment.
That makes sense to me. Thanks for double checking it.
Looking at https://github.com/WordPress/gutenberg/blob/trunk/packages/base-styles/_breakpoints.scss#L10 and elsewhere, I think I got this label + value relationship completely wrong.
The good news is this is the only place I've made that assumption so we can rename or delete it 😄 I might keep the comment there and remove the size.
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to:
This PR:
$viewport_sizeslast item to indicate that the final size isn't necessary technically (for now).Why?
Testing Instructions
There is only only one logic change on the frontend. The rest is formatting and renaming.
To test manually, enable the experiment:
In the editor, hide a block at all breakpoints.
Save the post and preview the frontend.
Inspect the hidden block, It should still be in the DOM but hidden by the
wp-block-hidden-desktop wp-block-hidden-mobile wp-block-hidden-tabletclasses.Tests should pass.