Build: deduplicate and minify embedded styles #74651
Open
+62
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves how we deal with style imports that we inline into the transpiled JS code. Two improvements:
styleelement. It checks if thestyleelement with the givendata-wp-hashattribute already exists, and prevents inserting duplicate styles. That can reduce style duplication a lot when libraries like@wordpress/uiare bundled many times with various chunks (blocks, routes etc.)cssnano. Makes the transpiled JS files smaller.We're still using
postcsshere for both CSS modules and minification. In the near future I'd like to switch tolightningcssbut they need to release a bugfixed version first.How to test
look at built files for:
packages/ui/build-module/form/primitives/fieldset/legend.mjsbuild/scripts/components/index.jsand verify that they both contain the new CSS-inserting code with minified CSS literals.