Block visibility supports: refactor metadata to use nested structure #74602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilize a nested 'viewport' object for visibility settings, ensuring consistent behavior across the block editor. Adjust tests to reflect the new structure and maintain functionality.
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +51 B (0%) Total Size: 3.05 MB
ℹ️ View Unchanged
|
ramonjd
commented
Jan 14, 2026
|
|
||
| if ( is_array( $block_visibility ) && ! empty( $block_visibility ) ) { | ||
| // Get viewport configuration from nested structure. | ||
| $viewport_config = $block_visibility['viewport'] ?? null; |
Member
Author
There was a problem hiding this comment.
This is pretty basic, but my general idea is that later, sources could define their own evaluation rules for when blocks are hidden.
This could be via filters, or some sort of registration pattern. Not sure yet.
Maybe theme.json if we want to build a UI around it.
12 tasks
t-hamano
approved these changes
Jan 15, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! Everything works well for me 👍
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
Jan 16, 2026
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to:
Refactors block visibility metadata to use a nested structure where viewport settings are stored under a
viewportkey.Note
The backport PR should be updated once a path is decided upon.
Why?
This change prepares the foundation for adding additional visibility sources (e.g., user role, time period) in the future.
See discussion over at: #72502 (comment)
How?
blockVisibility: { mobile: false }→blockVisibility: { viewport: { mobile: false } }blockVisibility: false(hidden everywhere) remains the sameNotes on future extensibility
This nested structure enables future extensibility for additional visibility sources:
Later plugins could register custom sources with each source managing its own configuration schema. Core logic could iterate through registered sources or via filter, e.g.,
apply_filters( 'block_visibility_sources', $sources )Testing Instructions
There should be no regressions from #74249
Enable experimental flag in
/wp-admin/admin.php?page=gutenberg-experimentsHere's some example HTML:
Example HTML
Check that the correct blocks hide in the correct viewports, and that there are no regressions from #74249