Block visibility based on screen size: don't subscribe to state in the hook #74481
+167
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m context, the intention is to reduce unnecessary store subscriptions.
|
Size Change: -5 B (0%) Total Size: 3.08 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
I'm just waiting for the performance tests to finish. I'm on my third cup of tea:
This should improve things. |
andrewserong
approved these changes
Jan 9, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Oh, too quick @Mamaduka 😄
LGTM too!
Member
Author
🎉 |
Member
In my experinces 99% of the time it's extra store subscription causing perf regression 😓 |
Member
Author
Thanks for confirming. I should have remembered that too. Appreciate @talldan picking it up and to you folks for the speedy review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #74379 (review)
Updated
useBlockVisibilityto accept block visibility and device type from context, with the intention to reduce unnecessary store subscriptions.Kudos to @talldan for picking up on it.
Here's the result of my local performance tests (note, they might not be reliable as I was listening to YouTube, working in an IDE with 10 AI agents running, and also mining Bitcoin at the same time)
If this doesn't work, I'll roll back #74379
Why?
Trying to fix a performance regression. See #74379 (review) and graph at https://www.codevitals.run/project/gutenberg/inserterHover
How?
useBlockVisibilityto accept options directly (noclientIdor store access)block.jsanduse-block-props/index.jsto pass data from existinguseSelectcallsblockVisibility = undefined,deviceType = 'desktop'Testing Instructions
Smoke test block visibility (test steps over at #74379)