-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix Floating UI packages dependencies #70553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The reason some CIs are failing is probably because they are pointing to a different branch and running |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Now The underlying reason seems to be that the version of the I guess that there are two possible ways to fundamentally solve this problem.
Either way, According to the changelog it should be fine to update to the latest version, but for now I want to pin the version by the command below: Furthermore, it appears that similar issues have occurred in the past: #48402 |
johnbillion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get to the root cause of this, but also it would be good to have the tests in Gutenberg and core passing again. Let's get this in.
|
@johnbillion Thanks for the review! I'd like to merge this pr for now to unblock other PRs and core development. I will follow up if necessary. Furthermore, I noticed that this PR also occurs in the |
* Fix Floating UI packages dependencies * Pin @floating-ui/react-dom version
* Fix Floating UI packages dependencies * Pin @floating-ui/react-dom version
|
I just cherry-picked this PR to the release/21.1 branch to get it included in the next release: d885c78 |
* Fix Floating UI packages dependencies * Pin @floating-ui/react-dom version
|
This PR was cherry-picked into the |
Originally reported at Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1751138157139149
What?
This fixes the CI failure by updating
package-lock.json.Why?
Somehow, the npm packages became inconsistent and started giving errors when running
npm ci:The packages haven't been updated recently, so it's unclear why this issue suddenly started happening.
How?
Run
npm install --package-lock-onlyTesting Instructions
Let's see if this PR passes CI.