Block Bindings: Rely on Text component instead of Truncate in bindings panel
#65007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Enhancement
SantosGuillamot
requested review from
artemiomorales,
cbravobernal and
jasmussen
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
64 tasks
SantosGuillamot
deleted the
update/remove-truncate-component-from-bindings
branch
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove usage of
Truncatecomponent and rely onTextcomponent withtruncateprop in the bindings panel.Why?
It seems
Truncateis not needed, and it will help with style consistency. It should palliate the issue mentioned here. And ifTextstyles change in the future, it will just work as expected.Additionally, it removes an extra
spanfrom the HTML.How?
Using the
truncateprop of theTextcomponent.Testing Instructions