Backmerge block renaming fixes/refactors from 6.4 branch into Gutenberg trunk #56386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Feature] Blocks
This comment was marked as resolved.
This comment was marked as resolved.
|
Size Change: +156 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
getdave
changed the title
getdave
changed the title
getdave
requested review from
Mamaduka,
ellatrix and
kevin940726
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
scruffian
reviewed
Nov 22, 2023
scruffian
approved these changes
Nov 22, 2023
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Code looks good and tests well
getdave
commented
Nov 22, 2023
Comment on lines
9
to
11
| const supportsBlockNaming = !! ( | ||
| true === metaDataSupport || metaDataSupport?.name | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I think this is a mistake.
Contributor
Author
There was a problem hiding this comment.
We only need to check for renaming support.
Contributor
Author
|
I believe the Puppeteer tests have actually passed despite them not reporting to Github. |
getdave
deleted the
update/backport-rename-ui-changes-from-6-4-branch
branch
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Back merges the refactors that were undertaken directly in the
wp/6.4branch to improve Block Renaming support.Namely:
Also fixes this Issue report.
Part of #55643
Why?
The WP 6.4 branch got ahead of this branch due to the nature of some bugfixes that had to land directly in the 6.4 branch because Gutenerg trunk had already progressed during the 6.4 Beta/RC cycle.
So now we bring Gutenberg back into line with the improvements in 6.4 whilst also retaining the improvements already in
trunk.How?
trunkis restored.Testing Instructions
Advancedpanel also behaves as expected and changes are synchronised to the List View.Headingblock (note: the block that is not selected).Renameoption once in the menu.Testing Instructions for Keyboard
Screenshots or screencast