Skip to content

Conversation

@ramonjd
Copy link
Member

@ramonjd ramonjd commented Jul 13, 2023

What?

Just another "just in case" PR.

Remove code in IS_GUTENBERG_PLUGIN block in navigation and file blocks.

Why?

  1. The are part of the interactivity API, which is not being shipped with 6.3
  2. As far as Core as concerned, it's dead code and won't run
  3. There's the potential to cause conflict as some contained functions have gutenbeg_ prefixes

How?

My grubby delete key

Testing Instructions

Navigation and File blocks should work as expected.

* @package WordPress
*/

// These functions are used for the __unstableLocation feature and only active
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failing E2E's are related 😢

So they could also either be gated, or even more interesting, a filter could take over the role: #52579

@ramonjd ramonjd closed this Jul 13, 2023
@ramonjd ramonjd deleted the update/wp-6.3-remove-gutenberg-functions branch July 13, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants