Skip to content

Conversation

@ockham
Copy link
Contributor

@ockham ockham commented Mar 2, 2023

What?

In the 6.2 compat layer, make WP_HTML_Tag_Processor's $html member protected to support subclassing.

Why?

For parity with Code in WP 6.2, authored by @dmsnell in WordPress/wordpress-develop#4112 and committed by @gziolo in r55402.

@ockham ockham requested review from adamziel, dmsnell and gziolo March 2, 2023 11:41
@ockham ockham requested a review from spacedmonkey as a code owner March 2, 2023 11:41
@ockham ockham self-assigned this Mar 2, 2023
@ockham ockham changed the title Tag Processor: Make html field protected Tag Processor: Make $html field protected Mar 2, 2023
@ockham ockham added this to the Gutenberg 15.3 milestone Mar 2, 2023
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing 🙌🏻

@ockham ockham merged commit 438bbc6 into trunk Mar 2, 2023
@ockham ockham deleted the update/protected-html-in-6-2-tag-processor branch March 2, 2023 13:24
@ockham
Copy link
Contributor Author

ockham commented Mar 2, 2023

I'll cherry-pick this to the release/15.3 branch so it'll make it into GB 15.3. (I've already set this PR's milestone accordingly.)

cc/ @priethor since I believe you're in charge of that release 😊

ockham added a commit that referenced this pull request Mar 2, 2023
In the 6.2 compat layer, make `WP_HTML_Tag_Processor`'s `$html` member `protected` to support subclassing.

This is for parity with Code in WordPress 6.2, see WordPress/wordpress-develop#4112 and [r55402](https://core.trac.wordpress.org/changeset/55402).
@ockham
Copy link
Contributor Author

ockham commented Mar 2, 2023

Cherry-picked to release/15.3 in 580b4f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants