Rnmobile/fix/disable controls when template lock is set #32495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
chipsnyder
approved these changes
Jun 8, 2021
Contributor
chipsnyder
left a comment
chipsnyder
left a comment
There was a problem hiding this comment.
LGTM tested with wordpress-mobile/gutenberg-mobile#3513 (review)
… gutenberg bridge
This fixes a but in the block inserter button and make the feature match the web functionality.
enejb
force-pushed
the
rnmobile/fix/disable-controls-when-templateLock-is-set
branch
from
8529138 to
2cf971b
Compare
mkevins
restored the
rnmobile/fix/disable-controls-when-templateLock-is-set
branch
2 tasks
mkevins
deleted the
rnmobile/fix/disable-controls-when-templateLock-is-set
branch
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the #31777 and fixes:
Description
This Pr helps us test the new layout grid block on the mobile editor.
It fixes the issues found in the layout grid block while testing wordpress-mobile/gutenberg-mobile#3513.
It fixes them by showing the disabled the add new block action went the block is set to insert any new blocks.
This happens when the parent defines a
templateLock="all". Which makes the mobile implementation match what we have on the web. Fixing wordpress-mobile/gutenberg-mobile#3583See
It also make the block action marked as disabled if the block does not present any block actions on the block.
Fixing wordpress-mobile/gutenberg-mobile#3582
See
How has this been tested?
Build the iOS app using
wordpress-mobile/WordPress-iOS#16543
Screenshots
See
Screen.Recording.2021-06-07.at.12.19.44.PM.mp4
Types of changes
Bug fixes.
Checklist:
*.native.jsfiles for terms that need renaming or removal).