Re-adding jsc-android to fix android demo build #23694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jul 4, 2020
guarani
approved these changes
Jul 6, 2020
Contributor
guarani
left a comment
guarani
left a comment
There was a problem hiding this comment.
Tested working great! Thanks @cameronvoell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23693
The linked issue above shows a new error when running the default process for running the android demo project. This change re-adds a recently removed dependency (removed in #23550) which seems to fix this issue.
How has this been tested?
npm installnpm run native startnpm run native androidChecklist: