Skip to content

chore(deps): bump accordion-js from 2.8.0 to 3.3.4#40

Closed
dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot/npm_and_yarn/accordion-js-3.3.4
Closed

chore(deps): bump accordion-js from 2.8.0 to 3.3.4#40
dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot/npm_and_yarn/accordion-js-3.3.4

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 5, 2023

Bumps accordion-js from 2.8.0 to 3.3.4.

Release notes

Sourced from accordion-js's releases.

Version 3.3.4

  • Update .npmignore

Version 3.3.3

  • Adjusted styles
  • Fixed a bug when defined IDs were overwritten
  • Fixed a bug when currFocusedIdx wasn't set correctly
  • Fixed a bug with transition event fired too often
  • Replaced deprecated keyCode event
  • Escape class names in selectors
  • ESLint: Enable no-unused-vars rule
  • pkg.json: Changed min Edge version to 80

Version 3.3.2

  • Moved execution of beforeOpen fn before panel calculation

Version 3.3.1

  • Fixed a bug when updateARIA wasn't fired when the closeAll function was called
  • openAll and closeAll will only work on open/close elements, added missing onClose & onOpen calls

Version 3.3.0

  • Added onlyChildNodes option
  • Fixed a bug with incorrect visiblity when openOnInit was set to 0 and more elements were loaded.
  • Added additional packages and settings to the gulp config

Version 3.2.0

  • Added .update() method
  • Updated packages

Version 3.1.1

  • Fixed accordion icon state

Version 3.1.0

  • Support for nested accordions

Version 3.0.0

The new major Accordion update is here! 🔥 Many new options have been added and the core has been updated to meet the new accessibility standards.

  • Refactoring & Optimization
  • Added keydown handlers (space, arrowUp, arrowDown, home, end)
  • Added openOnInit option,
  • Added collapse option
  • Added activeClass option
  • Added beforeOpen option
  • Added onOpen option
  • Added beforeClose option
  • Added onClose option
  • Added open method
  • Added close method

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [accordion-js](https://github.com/michu2k/Accordion) from 2.8.0 to 3.3.4.
- [Release notes](https://github.com/michu2k/Accordion/releases)
- [Commits](michu2k/Accordion@v2.8.0...v3.3.4)

---
updated-dependencies:
- dependency-name: accordion-js
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 5, 2023
@madwort
Copy link
Contributor

madwort commented Sep 5, 2023

should do some functional tests before merging things like this

@madwort
Copy link
Contributor

madwort commented Aug 12, 2024

There have been a lot of changes to the API in version 3.0.0, so if you are using previous versions of the accordion (2.8.0 and below), I recommend updating the package to the latest version with new structure and options.

@madwort
Copy link
Contributor

madwort commented Aug 12, 2024

weirdly, was just trying this out locally & although the docs for this component have been updated with a new API, our (old) config appears to still work with this version, and trivially switching over to the new config doesn't! (I must be holding something wrong...)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 8, 2025

Superseded by #51.

@dependabot dependabot bot closed this Jul 8, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/accordion-js-3.3.4 branch July 8, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant