Hugoを最新化する＆Hugo modulesを使う by mom0tomo · Pull Request #19 · WomenWhoGoTokyo/webpage

mom0tomo · 2025-12-14T05:23:25Z

概要

Hugoを最新化して、git submoduleではなく公式に推奨されているHugo modulesを使う方式に変更します。
https://gohugo.io/hugo-modules/

レビューの観点

プレビュー環境で見て崩れがないこと

cloudflare-workers-and-pages · 2025-12-14T05:23:35Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	web-womenwhogo-tokyo	`830b694`	Commit Preview URL Branch Preview URL	Dec 31 2025, 02:18 AM

Copilot

Pull request overview

This PR modernizes the Hugo setup by migrating from git submodules to Hugo modules for theme management, as recommended by Hugo's official documentation. The changes update the site to use Hugo's native module system, which provides better dependency management and version control.

Key changes:

Migration from git submodule to Hugo modules for the elate theme
Update of Hugo template syntax from .Site.Params to site.Params (partially completed)
Addition of go.mod/go.sum for Hugo module management
Configuration updates including new markup settings and module version requirements

Reviewed changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
themes/elate	Removed git submodule reference to elate theme
.gitmodules	Removed git submodule configuration
go.mod	Added Hugo modules configuration with theme dependency
go.sum	Added checksums for Hugo module dependencies
config.toml	Updated theme reference, added module configuration, and reformatted settings
layouts/partials/work.html	Updated template syntax and removed extra indentation
layouts/partials/intro.html	Updated template syntax and removed extra indentation
layouts/partials/about.html	Removed extra indentation (template syntax partially updated)
layouts/partials/services.html	Removed extra indentation (template syntax partially updated)
layouts/partials/testimonials.html	Removed extra indentation (template syntax partially updated)
README.md	Added documentation for local development and deployment
.gitignore	Minor formatting fix
.hugo_build.lock	Added Hugo build lock file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-14T05:27:05Z

layouts/partials/about.html

+				<h2 class="to-animate">{{ with .Site.Params.about.title }}{{ . | markdownify }}{{ end }}</h2>
+				<div class="row">
+					<div class="col-md-8 col-md-offset-2 subtext to-animate">
+						<h3>{{ with .Site.Params.about.description }}{{ . | markdownify }}{{ end }}</h3>
 					</div>
 				</div>
 			</div>
-			<div class="row">
+		</div>
+		<div class="row">
 			{{ range .Site.Params.about.item }}


Inconsistent use of .Site.Params instead of site.Params. While the file was updated to remove indentation, lines 5, 8, and 14 still use the old .Site.Params syntax. For consistency with other template files like work.html and intro.html which were updated to use site.Params, these should also be changed to site.Params.

確かに。直します

fixed: 3dd891b

layouts/partials/services.html

layouts/partials/testimonials.html

config.toml

Copilot · 2025-12-14T05:27:06Z

config.toml

+enableRobotsTXT = true
+canonifyURLs = true
+defaultContentLanguage = "ja"
+paginate = 10


Incorrect placement of top-level configuration options. Lines 15-18 (enableRobotsTXT, canonifyURLs, defaultContentLanguage, paginate) are placed after the [markup] section, making them appear as if they're part of the markup configuration. These should be moved to appear before the [module] section (lines 6-9) to be at the top level of the configuration where they belong.

fixed: 6c714e1

Copilot

Pull request overview

Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-14T09:34:42Z

config.toml

@@ -1,283 +1,344 @@
-baseURL = "localhost:1313"
+baseURL = "http://localhost:1313/"


The baseURL should not include the protocol and domain for localhost development. According to Hugo best practices, baseURL should be set to the production URL (not localhost). For local development, Hugo server automatically handles localhost URLs. Consider setting this to the actual production URL like "https://web.womenwhogo.tokyo" or similar, as localhost:1313 should only be used during local testing and Hugo's server will override it automatically.

Suggested change

baseURL = "http://localhost:1313/"

baseURL = "https://web.womenwhogo.tokyo/"

@mom0tomo

ご対応ありがとうございます！

こちらのCoplilotのコメント気になりますね🤔
Cloudflare あまりわかってないのですが、 Cloudflare Pages側で環境変数などで本番URLに上書きされる設定になっているんでしょうか？

mikkegt · 2025-12-14T10:49:58Z

@mom0tomo

プレ表示確認しました。問題ないです！

私が変なことを聞いていたら指摘してほしいですが、themes/elate ディレクトリが物理的に残っているっぽい？ですが、これは、段階的に Hugo modulesに移行するために残しているという感じでしょうか。

上記でコメントしたbaseURLの件と、こちらの件、合わせて2点が気になりましたが、他は大丈夫そうでした！

mom0tomo · 2025-12-21T08:46:38Z

確かにbaseURLの件は直したほうがいいですね！そしてテーマの空ディレクトリは残っていなさそうでした！ @mikkegt

mom0tomo added 5 commits December 14, 2025 14:17

fmt

7830178

add README

301f6a2

add lockfile

7286cf0

Hugoを最新化する

015f991

Hugo Modulesを利用する

f80e337

mom0tomo self-assigned this Dec 14, 2025

mom0tomo requested review from mi-bear and mikkegt as code owners December 14, 2025 05:23

mom0tomo requested a review from Copilot December 14, 2025 05:23

Copilot started reviewing on behalf of mom0tomo December 14, 2025 05:24 View session

Copilot AI reviewed Dec 14, 2025

View reviewed changes

mom0tomo added 3 commits December 14, 2025 18:21

fix config

6c714e1

site.Paramsを使う

3dd891b

remove deprecated settings

18c6405

mom0tomo requested a review from Copilot December 14, 2025 09:30

Copilot started reviewing on behalf of mom0tomo December 14, 2025 09:31 View session

Copilot AI reviewed Dec 14, 2025

View reviewed changes

baseURLを修正する

830b694

		@@ -1,283 +1,344 @@
		baseURL = "localhost:1313"
		baseURL = "http://localhost:1313/"

	baseURL = "http://localhost:1313/"
	baseURL = "https://web.womenwhogo.tokyo/"

Conversation

mom0tomo commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概要

レビューの観点

Uh oh!

cloudflare-workers-and-pages bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mom0tomo Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mom0tomo Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mom0tomo Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mikkegt Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

mikkegt commented Dec 14, 2025

Uh oh!

mom0tomo commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mom0tomo commented Dec 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 14, 2025 •

edited

Loading

mom0tomo commented Dec 21, 2025 •

edited

Loading