fix(deps): update dependency recharts to v3.8.1#431
fix(deps): update dependency recharts to v3.8.1#431WomB0ComB0 wants to merge 2 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 47 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdates the recharts dependency in package.json from version 3.8.0 to 3.8.1, a patch version increment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the recharts dependency to version 3.8.1. The review feedback highlights a potential crash in the custom chart tooltip component that should be addressed with a null check and suggests reordering the dependency list alphabetically to maintain consistency.
| "@vercel/speed-insights": "^2.0.0", | ||
| "@vis.gl/react-google-maps": "^1.7.1", | ||
| "recharts": "3.8.0", | ||
| "recharts": "3.8.1", |
There was a problem hiding this comment.
While updating to recharts@3.8.1 is beneficial for fixing internal tooltip crashes with sparse payloads, please note the following:
- Potential Crash in Custom Component: The custom
ChartTooltipContentimplementation insrc/components/ui/chart.tsx(lines 215-216) still performs a.filter()on thepayloadarray and accessesitem.typewithout a null check. This custom implementation may still crash ifrechartspasses an array containingundefinedornullentries. It is recommended to add a guard:.filter((item) => item && item.type !== 'none'). - Alphabetical Sorting: The
rechartsdependency is currently out of alphabetical order. It should be moved to followreact-resizable-panels(line 174) to maintain consistency with the rest of thedependencieslist and adhere to standardpackage.jsonformatting practices, which are typically enforced by theprettier-plugin-packagejsonalready present in this project.
This PR contains the following updates:
3.8.0→3.8.1Release Notes
recharts/recharts (recharts)
v3.8.1Compare Source
What's Changed
Bugfixes!
New Contributors
Full Changelog: recharts/recharts@v3.8.0...v3.8.1
Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.