fix(deps): update dependency lucide-react to v1#430
fix(deps): update dependency lucide-react to v1#430WomB0ComB0 wants to merge 2 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 175 files, which is 25 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (175)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the lucide-react dependency to version 1.7.0. This major version upgrade introduces several breaking changes, such as the removal of brand icons, a change in default accessibility behavior, and the removal of the UMD build, which could lead to errors and broken builds.
package.json
Outdated
| "jotai-effect": "^2.2.3", | ||
| "kbar": "0.1.0-beta.48", | ||
| "lucide-react": "0.577.0", | ||
| "lucide-react": "1.7.0", |
There was a problem hiding this comment.
This major version upgrade to lucide-react v1 introduces several breaking changes that may affect the application:
- Removal of brand icons: All brand icons have been removed. Any usage will result in errors.
- Default
aria-hidden=true: Icons are now hidden from screen readers by default. This changes the accessibility behavior for icons that were previously announced. - UMD build removal: The UMD build is no longer provided, which will break builds that rely on it.
WomB0ComB0
force-pushed
the
renovate/major-lucide-monorepo
branch
from
f3229d0 to
08c5c04
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 160: The project currently imports brand icons named Github and Linkedin
from lucide-react but lucide-react v1.x removed brand icons; update all import
sites that reference the Github and Linkedin symbols to use either custom SVG
React components (e.g., create GithubIcon and LinkedinIcon components and
replace the imports/usages) or switch to a brand-icon package such as
simple-icons (install simple-icons or simple-icons-react and import the
corresponding SiGithub/SiLinkedin icons) and update the import statements and
JSX usages accordingly (search for the Github and Linkedin identifiers in the
codebase and replace them with the new component names).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
1 participant
This PR contains the following updates:
0.577.0→1.8.0Release Notes
lucide-icons/lucide (lucide-react)
v1.8.0: Version 1.8.0Compare Source
What's Changed
text-selecttosquare-dashed-textby @jguddas in #3943initOnMounted: trueforuseSessionStorageinCarbonAdOverlayby @karsa-mistmere in #4275bookmark-officon by @ZeenatLawal in #4283New Contributors
Full Changelog: lucide-icons/lucide@1.7.0...1.8.0
v1.7.0: Version 1.7.0Compare Source
What's Changed
map-pin-searchicon by @TonySullivan in #4125New Contributors
Full Changelog: lucide-icons/lucide@1.6.0...1.7.0
v1.6.0: Version 1.6.0Compare Source
What's Changed
radio-officon by @kongsgard in #4138New Contributors
Full Changelog: lucide-icons/lucide@1.5.0...1.6.0
v1.5.0: Version 1.5.0Compare Source
What's Changed
beef-officon by @jguddas in #3816Full Changelog: lucide-icons/lucide@1.4.0...1.5.0
v1.4.0: Version 1.4.0Compare Source
What's Changed
sport-shoeicon by @Youya-ui in #3953New Contributors
Full Changelog: lucide-icons/lucide@1.3.0...1.4.0
v1.3.0: Version 1.3.0Compare Source
What's Changed
shield-cogicon by @KnarliX in #3902New Contributors
Full Changelog: lucide-icons/lucide@1.2.0...1.3.0
v1.2.0: Version 1.2.0Compare Source
What's Changed
line-styleicon by @dg-ac in #4030New Contributors
Full Changelog: lucide-icons/lucide@1.1.0...1.2.0
v1.1.0: Version 1.1.0Compare Source
What's Changed
lucide-react-nativeby @karsa-mistmere in #4199arrow-big-*icon by @jguddas in #3527signposticon by @jguddas in #3531circle-user-roundicon by @karsa-mistmere in #4165roadicon by @uibalint in #3014New Contributors
Full Changelog: lucide-icons/lucide@1.0.2...1.1.0
v1.0.1: Lucide V1 🚀Compare Source
After years of work and dedication, Lucide Version 1 has been officially released!. This milestone marks a significant achievement in our journey to provide a comprehensive and versatile icon library for developers and designers alike.
It's been quite a ride — especially over the past year. Lucide has grown to over 30 million downloads per week and is used by million of projects worldwide. This release is a testament to the hard work of our community and contributors who have helped shape Lucide into what it is today.
Thank you to everyone who has supported us along the way. We couldn't have done this without you!
What's New in Version 1? TLDR;
aria-hiddenis now set by default on icons.lucidepackage).lucide-vue-nextto@lucide/vue.@lucide/angularlucidepackage.See more at Lucide Version 1
v1.0.0: Version 1.0.0Compare Source
What's Changed
schoolicon by @jguddas in #4124gpuicon by @jguddas in #4147<svg>element in two icons that were inconsistent by @LukasKalbertodt in #4166cctv-officon by @rrod497 in #4162New Contributors
Full Changelog: lucide-icons/lucide@0.577.0...1.0.0
Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.
Summary by CodeRabbit