fix(deps): update dependency @effect/platform to ^0.96.0#425
fix(deps): update dependency @effect/platform to ^0.96.0#425WomB0ComB0 merged 2 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 28 minutes and 22 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the @effect/platform dependency from ^0.94.1 to ^0.96.0. This update introduces a critical breaking change in a transitive dependency, effect, which impacts the schema validation error handling in src/lib/http-clients/effect-fetcher.ts. Specifically, ParseResult.TreeFormatter.formatIssueSync and direct access to the issue property on ParseError are no longer valid, leading to runtime errors. The suggested fix is to use ParseResult.TreeFormatter.formatErrors(result.left.errors) at line 435 in the affected file.
| "dependencies": { | ||
| "@ducanh2912/next-pwa": "^10.2.9", | ||
| "@effect/platform": "^0.94.1", | ||
| "@effect/platform": "^0.96.0", |
There was a problem hiding this comment.
This update to @effect/platform from ^0.94.1 to ^0.96.0 pulls in a newer version of its transitive dependency effect, which contains breaking changes affecting your schema validation logic.
The code in src/lib/http-clients/effect-fetcher.ts uses ParseResult.TreeFormatter.formatIssueSync and accesses the issue property on a ParseError. These APIs have been removed/changed in recent versions of effect.
This will cause a runtime error whenever a schema validation fails. To fix this, the error handling logic in src/lib/http-clients/effect-fetcher.ts needs to be updated.
Specifically, at line 435, you should use ParseResult.TreeFormatter.formatErrors(result.left.errors) instead.
Example fix for src/lib/http-clients/effect-fetcher.ts:
// around line 435
const problems = ParseResult.TreeFormatter.formatErrors(result.left.errors);This is a critical issue that needs to be addressed before merging this dependency update.
1 participant
This PR contains the following updates:
^0.94.1→^0.96.0Release Notes
Effect-TS/effect (@effect/platform)
v0.96.0Compare Source
Patch Changes
f7bb09b,bd7552a,ad1a7eb,0d32048,0d32048]:v0.95.0Compare Source
Patch Changes
fc82e81,82996bc,4d97a61,f6b0960,8798a84]:Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.