-
Notifications
You must be signed in to change notification settings - Fork 10
New StackReference System to replace old APIReferences #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new system should: * allow users to specify the parser (plugin) to use. * always save the original stack. * print warning if item was not found in the referenced plugin, and use original stack as fallback.
* This is due to CustomCrafting using CustomItems (and therefor StackIdentifierParsers) inside its constructor
* Use player to construct ExecutableItems/Blocks if available in context * Add ItemCreateContext.Builder
# Conflicts: # buildSrc/src/main/kotlin/com.wolfyscript.wolfyutils.spigot.java-conventions.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old APIReferences got a bit clunky:
These are some parts that the new StackReferences plans to resolve, plus more:
This is a partial rework of Spigot Impl. of the ItemStackConfig & Better ItemReferences #35, and provides better compatibility than the current v5 system, hence it'll be implemented into v5 the same way to replace the current system.
However, since older versions of CustomCrafting very much rely on APIReferences, this update needs to keep backwards compatibility.
(And marked as deprecated and for removal!)
To-do: