Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit b0262d1 ☁️ Nx Cloud last updated this comment at |
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
efaafb1 to
a46224c
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
a46224c to
e330181
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
e330181 to
773a559
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
773a559 to
1c81b59
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
1c81b59 to
5144fea
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
5144fea to
dccdfe2
Compare
WolfSoko
changed the title
Owner
Author
⚠ Artifact update problemRenovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: package-lock.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.jsonFile name: package.json |
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
dccdfe2 to
d7b612c
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
d7b612c to
48ba761
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
48ba761 to
67ad4b2
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
67ad4b2 to
022093f
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
from
022093f to
6f1d3e9
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
5 times, most recently
from
e4ff122 to
992d8c9
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
3 times, most recently
from
be688a3 to
f9967c1
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
2 times, most recently
from
b64a2bf to
98cae81
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
5 times, most recently
from
e96f3c3 to
301f130
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
3 times, most recently
from
ef33b1d to
4d76858
Compare
WolfSoko
force-pushed
the
renovate-github/major-nx-monorepo
branch
2 times, most recently
from
ec0c096 to
ba790c2
Compare
Owner
Author
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRoot- Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@libs/awesome/package.json`:
- Around line 5-6: Die peerDependencies in libs/awesome/package.json deklarieren
"@angular/common" und "@angular/core" als "^16.0.0 || ^21.0.0", was falsch ist,
da die Bibliothek mit Angular 21.2.5 gebaut wurde; entferne die "^16.0.0 ||"
Range und setze beide Peer-Dependencies auf eine Angular‑21-only Range (z. B.
"^21.0.0" oder ">=21.0.0 <22.0.0") so dass "@angular/common" und "@angular/core"
nur Angular 21+ verlangen; alternativ, wenn Angular 16 Unterstützung nötig ist,
erstelle eine separate build-Pipeline und ein gesondertes package (oder separate
artifacts) kompiliert mit Angular 16 (Partial compilation) und veröffentliche
das separat.
In `@package.json`:
- Line 22: Die package.json enthält ein inkonsistentes Nx-Upgrade (z.B.
"@nx/angular": "22.6.1") ohne begleitende Migrationsdatei; führe lokal `npx nx
migrate `@nrwl/workspace`@22.6.1` (oder passenden Ziel-Release) aus, prüfe und
committe die erzeugten migrations.json und die aktualisierten
package.json/lockfile-Änderungen, führe anschließend `npm install` und `npx nx
migrate --run-migrations` aus, bewerte und löse alle auftretenden
Breaking-Change-Fixups in betroffenen Dateien (Suche nach "@nx/angular",
"@nrwl/*", migrations.json und aktualisierten Scripts), und pushe diese
Migration-Änderungen bevor du den Merge fortsetzt.
- Around line 28-30: package.json currently pins "typescript": "5.2.2" which is
incompatible with Angular 21; update the "typescript" dependency entry (the
"typescript" key) to a version in the required range (>=5.9.0 <6.0.0), save
package.json, then run your package manager to reinstall (npm/yarn/pnpm) and
regenerate the lockfile so the new TypeScript is used for build and compilation.
- Around line 14-21: Package version mismatch: ensure `@angular/core`,
`@angular/cli` and related DevKit/Schematics packages use the same patch version.
Update the package.json entries for "@angular/cli" and any "@angular-devkit/..."
or "@schematics/..." devDependencies to match "@angular/core" (e.g., change them
to "21.2.5") or alternatively downgrade "@angular/core" and siblings to the
shared version—make the patch version identical across "@angular/core",
"@angular/cli", "@angular-devkit/build-angular" and any "@angular-devkit/*" /
"@schematics/*" entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 70340389-323a-4cb6-84e0-98498ae7c7f2
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
libs/awesome/package.jsonpackage.json
| "@angular/platform-browser": "21.2.5", | ||
| "@angular/platform-browser-dynamic": "21.2.5", | ||
| "@angular/router": "21.2.5", | ||
| "@nx/angular": "22.6.1", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's examine the package.json file to confirm the Nx version changes
cat -n package.json | head -80Repository: WolfSoko/nx-clean
Length of output: 3024
🏁 Script executed:
# Check if there's a migrations.json file or any migration-related files
find . -name "*migrations*" -o -name "migrations.json" 2>/dev/null | head -20Repository: WolfSoko/nx-clean
Length of output: 43
🏁 Script executed:
# Look for any recent git changes or context
git log --oneline -20 2>/dev/null || echo "No git history available"Repository: WolfSoko/nx-clean
Length of output: 98
🏁 Script executed:
# Check if there are any .nx or migration-related configuration files
find . -name ".nx" -o -name "nx.json" 2>/dev/nullRepository: WolfSoko/nx-clean
Length of output: 70
🏁 Script executed:
# Check git diff to see actual changes in this PR
git diff HEAD~1 package.json 2>/dev/null | head -100Repository: WolfSoko/nx-clean
Length of output: 43
🏁 Script executed:
# Examine nx.json to understand the workspace state
cat -n nx.jsonRepository: WolfSoko/nx-clean
Length of output: 2203
🏁 Script executed:
# Check for any migration-related configuration or comments
grep -r "migration" . --include="*.json" --include="*.md" 2>/dev/null | grep -v node_modules | head -20Repository: WolfSoko/nx-clean
Length of output: 43
🏁 Script executed:
# Look at git status to see uncommitted changes
git status 2>/dev/null || echo "Not a git repo or no status available"Repository: WolfSoko/nx-clean
Length of output: 260
🏁 Script executed:
# Check git log to see version history more clearly
git log --oneline -10 2>/dev/nullRepository: WolfSoko/nx-clean
Length of output: 98
🏁 Script executed:
# Try to see the actual diff with more context
git show HEAD:package.json 2>/dev/null | head -80Repository: WolfSoko/nx-clean
Length of output: 2464
🏁 Script executed:
# Check if there was a previous commit we can compare against
git log --all --oneline -- package.json 2>/dev/null | head -10Repository: WolfSoko/nx-clean
Length of output: 659
🏁 Script executed:
# Look for any migration or update scripts
find . -name "*migrate*" -o -name "*.migration*" 2>/dev/null | grep -v node_modulesRepository: WolfSoko/nx-clean
Length of output: 43
Nx Major-Version-Upgrade ohne abgeschlossene Migration mergen.
Das Package.json zeigt @nx/angular und weitere Nx-Pakete auf 22.6.1, während Angular und verwandte Pakete noch auf 21.2.x laufen – eine Breaking-Change-Kombination. Kein migrations.json vorhanden, was bedeutet, dass nx migrate nie ausgeführt wurde. Nx-Dokumentation erfordert diesen Schritt, um Breaking Changes zu handhaben und abhängige Pakete zu aktualisieren. Dies ist ein kritischer Zustand und muss durch korrekten Migrationslauf geklärt werden, bevor ein Merge stattfindet.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 22, Die package.json enthält ein inkonsistentes
Nx-Upgrade (z.B. "@nx/angular": "22.6.1") ohne begleitende Migrationsdatei;
führe lokal `npx nx migrate `@nrwl/workspace`@22.6.1` (oder passenden
Ziel-Release) aus, prüfe und committe die erzeugten migrations.json und die
aktualisierten package.json/lockfile-Änderungen, führe anschließend `npm
install` und `npx nx migrate --run-migrations` aus, bewerte und löse alle
auftretenden Breaking-Change-Fixups in betroffenen Dateien (Suche nach
"@nx/angular", "@nrwl/*", migrations.json und aktualisierten Scripts), und pushe
diese Migration-Änderungen bevor du den Merge fortsetzt.
Comment on lines
+28
to
+30
| "@angular-devkit/build-angular": "21.2.3", | ||
| "@angular-devkit/core": "21.2.3", | ||
| "@angular-devkit/schematics": "21.2.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's locate and read the package.json file
find . -name "package.json" -type f | head -5Repository: WolfSoko/nx-clean
Length of output: 103
🌐 Web query:
Angular 21 TypeScript version compatibility requirements
💡 Result:
Angular 21.0.x requires TypeScript >= 5.9.0 and < 6.0.0 (i.e., TypeScript 5.9.x is supported; TypeScript 6.x is not). [1]
🏁 Script executed:
# Read the relevant lines from package.json
sed -n '25,35p' package.json
echo "---"
sed -n '70,75p' package.jsonRepository: WolfSoko/nx-clean
Length of output: 590
TypeScript-Version für Angular 21 zu alt.
Angular 21 erfordert TypeScript >=5.9.0 <6.0.0. Die aktuell installierte Version 5.2.2 (Zeile 73) ist nicht kompatibel und blockiert die Installation und Compilation des Projekts.
Fix außerhalb dieses Hunks
- "typescript": "5.2.2"
+ "typescript": "~5.9.0"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` around lines 28 - 30, package.json currently pins "typescript":
"5.2.2" which is incompatible with Angular 21; update the "typescript"
dependency entry (the "typescript" key) to a version in the required range
(>=5.9.0 <6.0.0), save package.json, then run your package manager to reinstall
(npm/yarn/pnpm) and regenerate the lockfile so the new TypeScript is used for
build and compilation.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
48-49:⚠️ Potential issue | 🟠 Major@typescript-eslint-Pakete müssen auf v8.x aktualisiert werden.
Bei einem Upgrade auf TypeScript 5.9 (erforderlich für Angular 21) müssen auch die
@typescript-eslint/*-Pakete aktualisiert werden. Version6.21.0unterstützt nur TypeScript bis 5.4.x. Auch Version 7.x unterstützt TypeScript 5.9 nicht.Für TypeScript 5.9 wird
@typescript-eslint/*Version 8.39.0 oder neuer benötigt.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 48 - 49, The package.json pins `@typescript-eslint` packages to 6.21.0 which is incompatible with TypeScript 5.9; update the "@typescript-eslint/eslint-plugin" and "@typescript-eslint/parser" entries (and any other `@typescript-eslint/`* entries) to at least 8.39.0 (prefer latest 8.x) in package.json, then regenerate lockfile (npm/yarn pnpm install) and run the linter/CI to ensure no new rule or parser changes break the build; also ensure any ESLint configs referencing old rules are adjusted for the 8.x compatibility.
♻️ Duplicate comments (3)
package.json (3)
73-73:⚠️ Potential issue | 🔴 CriticalTypeScript-Version ist inkompatibel mit Angular 21.
Wie bereits in früheren Reviews angemerkt: Angular 21 erfordert TypeScript
>=5.9.0 <6.0.0. Die aktuelle Version5.2.2verhindert sowohlnpm installals auch die Kompilierung.🔧 Erforderliche Änderung
- "typescript": "5.2.2" + "typescript": "~5.9.0",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 73, Die package.json enthält eine inkompatible TypeScript-Version ("typescript": "5.2.2") mit Angular 21; aktualisiere den "typescript" Eintrag in package.json auf eine mit Angular 21 kompatible Version (z. B. setze den Wert auf ">=5.9.0 <6.0.0" oder eine konkrete 5.9.x Release) und führe danach npm install / CI-Build aus, um sicherzustellen, dass die Abhängigkeiten und die Kompilierung erfolgreich sind.
14-22:⚠️ Potential issue | 🔴 CriticalAngular- und Nx-Paketversionen erfordern zusätzliche Konfigurationsänderungen.
Wie bereits in früheren Reviews angemerkt, gibt es hier mehrere Kompatibilitätsprobleme:
@angular/cli (~21.2.0) vs.
@angular/core(21.2.6): Die Tilde-Range könnte zu einer anderen Patch-Version auflösen als die exakt gepinnten Core-Pakete.@nx/angular 22.6.1 ohne Migration: Ein Major-Upgrade von Nx 17 → 22 erfordert das Ausführen von
nx migrateund das Committen der resultierendenmigrations.json.Veraltete Executor-Referenzen: Die Context-Snippets zeigen, dass
apps/cleaner/project.jsonnoch@angular-devkit/build-angular:browser-esbuildund@angular-devkit/build-angular:dev-serververwendet. Ab Angular 18+ wurden diese durch@angular/build:applicationund@angular/build:dev-serverersetzt.,
#!/bin/bash # Prüfe auf veraltete Executor-Referenzen in project.json Dateien echo "=== Suche nach veralteten Angular DevKit Executors ===" rg -n "browser-esbuild|dev-server" --glob "*.json" -g "!node_modules" -g "!package*.json" echo "" echo "=== Prüfe ob migrations.json existiert ===" fd "migrations.json" --type f🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 14 - 22, package.json lists mixed Angular/Nx versions and may leave `@angular/cli` with a tilde range; update `@angular/cli` to the exact patch that matches `@angular/core` (e.g., 21.2.6) to avoid resolution drift, then run nx migrate to upgrade Nx (reflecting `@nx/angular` 22.6.1), commit the generated migrations.json, and execute migrations; also update any project.json executor entries (e.g., in apps/cleaner/project.json) replacing "@angular-devkit/build-angular:browser-esbuild" with "@angular/build:application" and "@angular-devkit/build-angular:dev-server" with "@angular/build:dev-server", search the repo for "browser-esbuild" and "dev-server" to catch all occurrences, and re-run the provided verification script to confirm no outdated executors remain and that migrations.json is present.
64-65:⚠️ Potential issue | 🔴 Criticalng-packagr 21.2.1 blockiert die Installation.
ng-packagr@21.2.1erforderttypescript@">=5.9 <6.0", aber die aktuelle TypeScript-Version ist5.2.2(Zeile 73). Dies ist die Ursache für die in den PR-Kommentaren gemeldetennpm ERESOLVE-Fehler.Die TypeScript-Abhängigkeit muss auf
~5.9.0aktualisiert werden, um die Installation zu ermöglichen.,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 64 - 65, ng-packagr@21.2.1 requires TypeScript >=5.9 <6.0 but package.json currently pins "typescript": "5.2.2", causing ERESOLVE install failures; update the TypeScript dependency entry in package.json from "5.2.2" to a compatible version spec such as "~5.9.0" so it satisfies ng-packagr's peer requirement and allows installation. Locate the "typescript" entry in package.json and change its version string to "~5.9.0" (keeping the existing package name "typescript" and leaving other deps like "ng-packagr" and "nx" unchanged), then run npm install to verify resolution.
🧹 Nitpick comments (1)
package.json (1)
28-36: Inkonsistente Patch-Versionen zwischen Angular-Paketen.Die DevKit-Pakete (
@angular-devkit/*,@schematics/angular) sind auf21.2.3gepinnt, während die Core-Pakete (@angular/core,@angular/compiler-cli,@angular/language-service) auf21.2.6stehen. Für maximale Stabilität sollten alle Angular-Pakete auf derselben Patch-Version synchronisiert werden.🔧 Vorgeschlagene Anpassung
- "@angular-devkit/build-angular": "21.2.3", - "@angular-devkit/core": "21.2.3", - "@angular-devkit/schematics": "21.2.3", + "@angular-devkit/build-angular": "21.2.6", + "@angular-devkit/core": "21.2.6", + "@angular-devkit/schematics": "21.2.6", ... - "@angular/cli": "~21.2.0", + "@angular/cli": "21.2.6", ... - "@schematics/angular": "21.2.3", + "@schematics/angular": "21.2.6",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 28 - 36, Die Angular-Paketversionen sind inkonsistent: synchronisiere die Patch-Versionen so dass DevKit- und Core-Pakete dieselbe Patch-Release verwenden (z.B. setze "@angular-devkit/build-angular", "@angular-devkit/core", "@angular-devkit/schematics", "@angular/cli", "@angular/compiler-cli", "@angular/language-service" und "@schematics/angular" alle auf denselben Patch-Level wie "@angular/core" oder umgekehrt); aktualisiere die Einträge in package.json für die genannten Pakete auf dieselbe Patch-Version und führe danach npm/yarn install aus, um Lockfile und node_modules zu aktualisieren.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 25: Die package.json Eintragung für "zone.js" ist auf 0.14.2 und damit
nicht kompatibel mit Angular 21; aktualisiere die "zone.js" Abhängigkeit in
package.json auf eine kompatible Version (z. B. "~0.15.0" oder "~0.16.0") oder
entferne den Eintrag und migriere die App explizit auf zoneless change
detection; passe ggf. zugehörige Imports/Polyfills und die
Build/Testing-Konfigurationen an (suche nach "zone.js" und "package.json" im
Repo, z. B. polyfills.ts oder main.ts), führe npm install und die
Anwendungstests danach aus.
---
Outside diff comments:
In `@package.json`:
- Around line 48-49: The package.json pins `@typescript-eslint` packages to 6.21.0
which is incompatible with TypeScript 5.9; update the
"@typescript-eslint/eslint-plugin" and "@typescript-eslint/parser" entries (and
any other `@typescript-eslint/`* entries) to at least 8.39.0 (prefer latest 8.x)
in package.json, then regenerate lockfile (npm/yarn pnpm install) and run the
linter/CI to ensure no new rule or parser changes break the build; also ensure
any ESLint configs referencing old rules are adjusted for the 8.x compatibility.
---
Duplicate comments:
In `@package.json`:
- Line 73: Die package.json enthält eine inkompatible TypeScript-Version
("typescript": "5.2.2") mit Angular 21; aktualisiere den "typescript" Eintrag in
package.json auf eine mit Angular 21 kompatible Version (z. B. setze den Wert
auf ">=5.9.0 <6.0.0" oder eine konkrete 5.9.x Release) und führe danach npm
install / CI-Build aus, um sicherzustellen, dass die Abhängigkeiten und die
Kompilierung erfolgreich sind.
- Around line 14-22: package.json lists mixed Angular/Nx versions and may leave
`@angular/cli` with a tilde range; update `@angular/cli` to the exact patch that
matches `@angular/core` (e.g., 21.2.6) to avoid resolution drift, then run nx
migrate to upgrade Nx (reflecting `@nx/angular` 22.6.1), commit the generated
migrations.json, and execute migrations; also update any project.json executor
entries (e.g., in apps/cleaner/project.json) replacing
"@angular-devkit/build-angular:browser-esbuild" with
"@angular/build:application" and "@angular-devkit/build-angular:dev-server" with
"@angular/build:dev-server", search the repo for "browser-esbuild" and
"dev-server" to catch all occurrences, and re-run the provided verification
script to confirm no outdated executors remain and that migrations.json is
present.
- Around line 64-65: ng-packagr@21.2.1 requires TypeScript >=5.9 <6.0 but
package.json currently pins "typescript": "5.2.2", causing ERESOLVE install
failures; update the TypeScript dependency entry in package.json from "5.2.2" to
a compatible version spec such as "~5.9.0" so it satisfies ng-packagr's peer
requirement and allows installation. Locate the "typescript" entry in
package.json and change its version string to "~5.9.0" (keeping the existing
package name "typescript" and leaving other deps like "ng-packagr" and "nx"
unchanged), then run npm install to verify resolution.
---
Nitpick comments:
In `@package.json`:
- Around line 28-36: Die Angular-Paketversionen sind inkonsistent:
synchronisiere die Patch-Versionen so dass DevKit- und Core-Pakete dieselbe
Patch-Release verwenden (z.B. setze "@angular-devkit/build-angular",
"@angular-devkit/core", "@angular-devkit/schematics", "@angular/cli",
"@angular/compiler-cli", "@angular/language-service" und "@schematics/angular"
alle auf denselben Patch-Level wie "@angular/core" oder umgekehrt); aktualisiere
die Einträge in package.json für die genannten Pakete auf dieselbe Patch-Version
und führe danach npm/yarn install aus, um Lockfile und node_modules zu
aktualisieren.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6ac61ffc-9d09-48c4-b944-f23b9e99110e
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
libs/awesome/package.jsonpackage.json
✅ Files skipped from review due to trivial changes (1)
- libs/awesome/package.json
| "@nx/angular": "22.6.1", | ||
| "rxjs": "~7.8.1", | ||
| "tslib": "^2.5.0", | ||
| "zone.js": "0.14.2" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Angular 21 zone.js version requirements compatibility
💡 Result:
Angular 21 has zoneless change detection as the default for new projects, meaning zone.js is no longer included or required by default. For applications that opt to use zone-based change detection (via provideZoneChangeDetection), @angular/core v21 requires zone.js ~0.15.0 or ~0.16.0 as an optional peer dependency. New Angular 21 projects generated by ng new do not include zone.js in package.json or polyfills. Existing projects can migrate to zoneless by removing zone.js and using signals for state management, or retain zone.js by explicitly providing zone change detection and including the appropriate version.
Citations:
- 1: https://angular.dev/reference/versions
- 2: https://angular.dev/guide/zoneless
- 3: https://registry.npmjs.org/%40angular%2Fcore
- 4: https://github.com/angular/angular/blob/main/packages/core/package.json
- 5: fix(@angular/core): mark
zone.jsas an optional peer dependency angular/angular#61616
zone.js Version für Angular 21 aktualisieren.
zone.js 0.14.2 ist mit Angular 21 nicht kompatibel. Wenn zone-basierte Änderungserkennung verwendet wird, ist zone.js ~0.15.0 oder ~0.16.0 erforderlich. Alternativ: Angular 21 unterstützt standardmäßig zoneless change detection – zone.js kann entfernt und die Anwendung auf zoneless migriert werden.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 25, Die package.json Eintragung für "zone.js" ist auf
0.14.2 und damit nicht kompatibel mit Angular 21; aktualisiere die "zone.js"
Abhängigkeit in package.json auf eine kompatible Version (z. B. "~0.15.0" oder
"~0.16.0") oder entferne den Eintrag und migriere die App explizit auf zoneless
change detection; passe ggf. zugehörige Imports/Polyfills und die
Build/Testing-Konfigurationen an (suche nach "zone.js" und "package.json" im
Repo, z. B. polyfills.ts oder main.ts), führe npm install und die
Anwendungstests danach aus.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
48-49: Aktualisieren Sie@typescript-eslintauf v8.x.Version 6.21.0 erfüllt zwar die Peer-Dependency-Anforderung (
^6.13.2 || ^7.0.0), aber Nx 22 arbeitet typischerweise mit@typescript-eslintv8.x. Verwenden Sienx migrate latest, um kompatible Versionen zu installieren.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 48 - 49, Die Abhängigkeiten "@typescript-eslint/eslint-plugin" und "@typescript-eslint/parser" sind auf 6.21.0 gesetzt; aktualisiere beide auf eine 8.x-kompatible Version (z. B. "^8.0.0") so dass sie mit Nx 22 zusammenarbeiten, führe anschließend "nx migrate latest" gefolgt von der Installation (npm/yarn install) aus, prüfe und löse ggf. peer-dependency-Konflikte und verifiziere die Änderungen durch Ausführen von lint/CI; referenziere die Paketnamen "@typescript-eslint/eslint-plugin" und "@typescript-eslint/parser" beim Update.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@package.json`:
- Around line 48-49: Die Abhängigkeiten "@typescript-eslint/eslint-plugin" und
"@typescript-eslint/parser" sind auf 6.21.0 gesetzt; aktualisiere beide auf eine
8.x-kompatible Version (z. B. "^8.0.0") so dass sie mit Nx 22 zusammenarbeiten,
führe anschließend "nx migrate latest" gefolgt von der Installation (npm/yarn
install) aus, prüfe und löse ggf. peer-dependency-Konflikte und verifiziere die
Änderungen durch Ausführen von lint/CI; referenziere die Paketnamen
"@typescript-eslint/eslint-plugin" und "@typescript-eslint/parser" beim Update.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f3bf117f-085c-482a-aad4-204e1d5ab46c
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
libs/awesome/package.jsonpackage.json
✅ Files skipped from review due to trivial changes (1)
- libs/awesome/package.json
There was a problem hiding this comment.
♻️ Duplicate comments (1)
package.json (1)
64-73:⚠️ Potential issue | 🔴 CriticalTypeScript vor dem Merge auf den Angular-21-Range anheben.
Mit dem Sprung auf Angular 21 bleibt
typescripthier bei5.2.2und liegt damit außerhalb des offiziell unterstützten Bereichs (>=5.9.0 <6.0.0). Das blockiert Installations- und Build-Pfade schon auf Manifest-Ebene. (angular.dev)🛠️ Vorschlag
- "typescript": "5.2.2" + "typescript": "~5.9.0"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 64 - 73, The package.json currently pins "typescript": "5.2.2", which is outside Angular 21's supported range; update the "typescript" dependency entry (the "typescript" key in package.json) to a version that satisfies Angular 21 (e.g. "^5.9.0" or any >=5.9.0 <6.0.0), then reinstall to update the lockfile (npm/yarn/pnpm install) and run the build/tests to catch any downstream adjustments (e.g. ts-jest or other tooling) needed after the TypeScript bump.
🧹 Nitpick comments (2)
package.json (2)
2-4: Node-Range im Root-Manifest sichtbar machen.Nach dem Upgrade auf Angular 21 sind nur noch Node
^20.19.0 || ^22.12.0 || ^24.0.0offiziell unterstützt. Einengines-Eintrag würde diese Anforderung in lokalen Setups und in CI früh sichtbar machen. (angular.dev)💡 Vorschlag
"name": "nx-clean", "version": "0.0.0", + "engines": { + "node": "^20.19.0 || ^22.12.0 || ^24.0.0" + }, "license": "MIT",Also applies to: 14-36
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 2 - 4, Füge im root package.json einen "engines" Eintrag hinzu, der die von Angular 21 unterstützten Node-Versionen erzwingt: "engines": { "node": ">=20.19.0 <25 || >=22.12.0 <23" } (oder exakt als "^20.19.0 || ^22.12.0 || ^24.0.0", je nach Präferenz), damit lokale Setups und CI frühzeitig fehlschlagen; zusätzlich spiegel die gleiche "engines.node" Vorgabe in den anderen betroffenen Manifests (Einträge 14–36) damit alle Pakete dieselbe Node-Range dokumentieren und durch Tools/CI erkannt werden.
40-45: Nx-Migration für Jest-Setup vollständig ausführen.
jest-preset-angularbleibt auf13.1.6, während Nx auf22.6.2sprang. Das ist kein Kompatibilitätsproblem, aber die Setup-Dateien nutzen ein veraltetes Pattern:import 'jest-preset-angular/setup-jest'(veraltet seit jest-preset-angular 16.0.0). Nx 22.6.2 erwartet die Modernisierung auf das neue Pattern:import { setupZoneTestEnv } from 'jest-preset-angular/setup-env/zone'; setupZoneTestEnv();Lauf
nx migrate --run-migrations, um die automatische Codemod-Migrationupdate-jest-preset-angular-setupanzuwenden. Diese aktualisiert jest-preset-angular auf 16.0.0+ und modernisiert die Setup-Dateien inapps/cleaner/src/test-setup.tsundlibs/awesome/src/test-setup.ts.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 40 - 45, The repository still uses the old jest-preset-angular setup import ("import 'jest-preset-angular/setup-jest'") while Nx was bumped; run the Nx migration and apply the codemod by executing "nx migrate --run-migrations" to run the update-jest-preset-angular-setup migration, update package.json to bump jest-preset-angular to 16.x+, and edit your test setup files (e.g., test-setup.ts) to replace the old import with the new pattern: import { setupZoneTestEnv } from 'jest-preset-angular/setup-env/zone'; then call setupZoneTestEnv(); so the setup matches the modern jest-preset-angular API.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@package.json`:
- Around line 64-73: The package.json currently pins "typescript": "5.2.2",
which is outside Angular 21's supported range; update the "typescript"
dependency entry (the "typescript" key in package.json) to a version that
satisfies Angular 21 (e.g. "^5.9.0" or any >=5.9.0 <6.0.0), then reinstall to
update the lockfile (npm/yarn/pnpm install) and run the build/tests to catch any
downstream adjustments (e.g. ts-jest or other tooling) needed after the
TypeScript bump.
---
Nitpick comments:
In `@package.json`:
- Around line 2-4: Füge im root package.json einen "engines" Eintrag hinzu, der
die von Angular 21 unterstützten Node-Versionen erzwingt: "engines": { "node":
">=20.19.0 <25 || >=22.12.0 <23" } (oder exakt als "^20.19.0 || ^22.12.0 ||
^24.0.0", je nach Präferenz), damit lokale Setups und CI frühzeitig
fehlschlagen; zusätzlich spiegel die gleiche "engines.node" Vorgabe in den
anderen betroffenen Manifests (Einträge 14–36) damit alle Pakete dieselbe
Node-Range dokumentieren und durch Tools/CI erkannt werden.
- Around line 40-45: The repository still uses the old jest-preset-angular setup
import ("import 'jest-preset-angular/setup-jest'") while Nx was bumped; run the
Nx migration and apply the codemod by executing "nx migrate --run-migrations" to
run the update-jest-preset-angular-setup migration, update package.json to bump
jest-preset-angular to 16.x+, and edit your test setup files (e.g.,
test-setup.ts) to replace the old import with the new pattern: import {
setupZoneTestEnv } from 'jest-preset-angular/setup-env/zone'; then call
setupZoneTestEnv(); so the setup matches the modern jest-preset-angular API.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d5c4563a-51af-4c1d-a0b3-ccf8283e8337
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
libs/awesome/package.jsonpackage.json
✅ Files skipped from review due to trivial changes (1)
- libs/awesome/package.json
There was a problem hiding this comment.
♻️ Duplicate comments (1)
package.json (1)
14-35:⚠️ Potential issue | 🔴 CriticalBegleit-Bumps für Angular 21 fehlen.
Angular 21 braucht TypeScript
>=5.9.0 <6.0.0. Zusätzlich istzone.jsin Angular v21 nur noch für zone-basierte Setups relevant;@nx/angularzieht es für diesen Sprung auf~0.16.0nach. Mittypescriptauf Line 73 (5.2.2) undzone.jsauf Line 25 (0.14.2) bleibt die Paketmenge hinter diesem Hunk inkonsistent. (angular.dev)🛠️ Begleit-Änderungen außerhalb dieses Hunks
"dependencies": { - "zone.js": "0.14.2" + "zone.js": "~0.16.0" }, "devDependencies": { - "typescript": "5.2.2" + "typescript": "~5.9.0" }Also applies to: 64-65
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 14 - 35, The package versions are inconsistent for Angular 21: update the "typescript" devDependency to a version matching Angular 21's requirement (>=5.9.0 <6.0.0) and bump "zone.js" to the Angular-21 compatible ~0.16.0, and ensure any related tooling such as "@nx/angular" remains compatible with those changes; locate the "typescript" entry (around lines referenced in the diff) and the "zone.js" entry and change their versions accordingly, and review the related devDependencies (e.g., "@angular-devkit/*" and "@angular/cli") to ensure compatibility with TypeScript 5.9-era Angular 21.2.x — also apply the same updates noted for the duplicate locations (lines 64-65).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@package.json`:
- Around line 14-35: The package versions are inconsistent for Angular 21:
update the "typescript" devDependency to a version matching Angular 21's
requirement (>=5.9.0 <6.0.0) and bump "zone.js" to the Angular-21 compatible
~0.16.0, and ensure any related tooling such as "@nx/angular" remains compatible
with those changes; locate the "typescript" entry (around lines referenced in
the diff) and the "zone.js" entry and change their versions accordingly, and
review the related devDependencies (e.g., "@angular-devkit/*" and
"@angular/cli") to ensure compatibility with TypeScript 5.9-era Angular 21.2.x —
also apply the same updates noted for the duplicate locations (lines 64-65).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d859e90f-6dc9-4a12-853d-4314c5884aea
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
libs/awesome/package.jsonpackage.json
✅ Files skipped from review due to trivial changes (1)
- libs/awesome/package.json
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
17.0.2→21.2.817.0.2→21.2.817.0.2→21.2.817.0.1→21.3.117.0.1→21.3.117.0.1→21.3.117.0.4→21.2.10~17.0.0→~21.2.017.0.4→21.2.10^16.0.0→^16.0.0 || ^21.0.017.0.4→21.2.1017.0.4→21.2.1017.0.4→21.2.10^16.0.0→^16.0.0 || ^21.0.017.0.4→21.2.1017.0.4→21.2.1017.0.4→21.2.1017.0.4→21.2.1017.0.4→21.2.1017.1.3→22.7.017.1.3→22.7.017.1.3→22.7.017.1.3→22.7.017.1.3→22.7.017.1.3→22.7.017.0.2→21.2.817.0.2→21.2.317.1.3→22.7.0Release Notes
angular/angular-cli (@angular-devkit/build-angular)
v21.2.8: 21.2.8Compare Source
@angular/cli
@angular-devkit/build-angular
@angular/build
v21.2.7Compare Source
@angular/cli
@angular/build
v21.2.6Compare Source
@angular/cli
@angular/build
v21.2.5Compare Source
@angular/cli
@angular/ssr
v21.2.4Compare Source
@angular/cli
@angular/build
@angular/ssr
v21.2.3Compare Source
@angular/cli
@angular/build
@angular/ssr
v21.2.2Compare Source
@angular/cli
@angular/build
CHROME_BINfor vitest playwright providerv21.2.1Compare Source
@angular/cli
ng add@schematics/angular
@angular-devkit/build-angular
@angular/build
vi.mockfor non-relative importsng-package.jsonin unit-test builderng servewith i18n@angular/ssr
v21.2.0Compare Source
@angular/cli
semver.validand throw an error if invalid@schematics/angular
@angular/build
allowedHostsin dev-serverv21.1.5Compare Source
@angular/ssr
v21.1.4Compare Source
@angular/build
v21.1.3Compare Source
@schematics/angular
@angular-devkit/build-angular
v21.1.2Compare Source
@angular-devkit/schematics-cli
@angular-devkit/architect
@angular/build
v21.1.1Compare Source
@angular/cli
@schematics/angular
@angular/build
v21.1.0Compare Source
@angular/cli
ng addversion discovery@schematics/angular
refactor-jasmine-vitest@angular/build
ng servewith SSR (#31722)v21.0.6Compare Source
@angular/ssr
v21.0.5Compare Source
@angular/cli
@schematics/angular
| Commit
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate.