Open
Conversation
- Properly delimit datagrams. Only one datagram in recv() et al result. - Address info correct in recvfrom() - If a datagram not completely consumed on recv() et al, then remainder is discarded. - Removed udp_remaining(). It was an API not tied to a socket, so meaningless. - UDP_SOCK method for keeping track of datagram processing replaced, since it was not tied to a socket.
|
Your changes are probably better targeted at https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k |
chabala
added a commit
to chabala/Adafruit_CircuitPython_Wiznet5k
that referenced
this pull request
Apr 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves some problems described in issues #1 and #2 at tom24/RP2040-HAT-CircuitPython.
In summary, UDP handling is improved.