feat: utilize nats-io jwt claims validation prior to signing#166
Merged
choufraise merged 2 commits intomainfrom Mar 18, 2026
Merged
feat: utilize nats-io jwt claims validation prior to signing#166choufraise merged 2 commits intomainfrom
choufraise merged 2 commits intomainfrom
Conversation
Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
Instead of doing our own minimalistic claims validation we should rely on the existing validation mechanism provided by the nats-io jwt lib. Bump nats-io/jwt/v2 to v2.8.1 ensure multi-import of same service from different accounts (applicable in e.g. JetStream Flow Control case (`$JS.FC.>`). Verify using local test. Closes: #165 Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
choufraise
commented
Mar 18, 2026
choufraise
commented
Mar 18, 2026
henriropp
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing our own minimalistic claims validation we should rely on the existing validation mechanism provided by the nats-io jwt lib.
Bump nats-io/jwt/v2 to v2.8.1 ensure multi-import of same service from different accounts (applicable in e.g. JetStream Flow Control case (
$JS.FC.>). Verify using local test.Closes: #165