feat: account manager to sign User JWT#161
Merged
choufraise merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
choufraise
force-pushed
the
feat/stricter-user-jwt-signing
branch
from
9702a82 to
4837d92
Compare
Today User Manager has its own (duplicated) code to look up the Account Signing Key. Since this has been strictened up and the Account Manager should be the sole manager dealing with Account related secrets, we should let the Account Manager be the entity (approving and) signing the User JWTs created during User reconciliation. Signed-off-by: Thobias Karlsson <thobias.karlsson@gmail.com>
choufraise
force-pushed
the
feat/stricter-user-jwt-signing
branch
from
4837d92 to
a728521
Compare
kejne
approved these changes
Mar 16, 2026
henriropp
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today User Manager has its own (duplicated) code to look up the Account Signing Key. Since this has been strictened up and the Account Manager should be the sole manager dealing with Account related secrets, we should let the Account Manager be the entity (approving and) signing the User JWTs created during User reconciliation.