Feat/wallet tests

[WillianSilva51]

This pull request introduces several improvements and fixes across the API and Telegram bot integration, focusing on user experience, validation, and code clarity. The main highlights include enhanced validation for wallet and transaction operations, a new configuration menu in the Telegram bot, and improved error handling. Minor changes address formatting, typo corrections, and test reliability.

Validation and Error Handling Enhancements:

• Added user existence validation in FindWalletByUserIdService, throwing a ResourceNotFoundException if the user does not exist before fetching wallets.
• Improved transaction editing flow to handle invalid fields and business rule violations gracefully, providing clear feedback to users. [1] [2]
• Updated UpdateWalletService to check for duplicate wallet names and handle database integrity violations with specific exceptions.

Telegram Bot Improvements:

• Introduced a new ConfigCallbackHandler and related menu options, separating configuration actions (login, delete user) from the main menu for better UX. [1] [2] [3] [4]
• Clarified error messages in transaction deletion and editing handlers, and improved prompts for transaction field editing. [1] [2] [3]
• Adjusted wallet balance formatting in selection messages for consistency.

Code and Test Quality:

• Refactored CreateWalletService to use constructor injection for maximum wallet limit, improving testability and clarity. [1] [2]
• Corrected typos and improved test descriptions for better readability and reliability in user service tests. [1] [2] [3] [4]

CI Workflow:

• Enhanced Maven CI workflow to capture and summarize test results directly in GitHub step summary, replacing artifact uploads with inline summaries.

[Copilot]

Pull request overview

This PR introduces comprehensive test coverage for wallet services and improves validation, error handling, and user experience across the application. The changes include new test files for all wallet service operations, enhancements to the Telegram bot interface with a new configuration menu, and various code quality improvements.

Changes:

• Added complete test coverage for wallet services (Create, Update, Delete, Find, GetBalance)
• Enhanced validation in wallet operations with duplicate name checking and user existence validation
• Introduced a new configuration menu in the Telegram bot separating settings from the main menu
• Refactored CreateWalletService to use constructor injection for the maximum wallet limit
• Minor fixes including typo corrections, improved error messages, and test reliability improvements

Reviewed changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
UpdateWalletServiceTest.java	New comprehensive test file covering update scenarios, authorization, and duplicate name validation
GetBalanceByWalletAndUserServiceTest.java	New test file for wallet balance retrieval functionality
FindWalletByUserIdTest.java	New test file covering paginated wallet listing with user validation
FindWalletByIdServiceTest.java	New test file for single wallet retrieval
DeleteWalletByIdServiceTest.java	New test file covering wallet deletion with authorization checks
CreateWalletServiceTest.java	New comprehensive test file for wallet creation scenarios
UpdateUserServiceTest.java	Fixed typo in test description and added missing password encoder mock
ListUsersServiceTest.java	Fixed grammatical error in test description
CreateUserServiceTest.java	Fixed typo in test description
UserPersistenceAdapter.java	Added existsById implementation to support user validation
MenuUtils.java	Updated main menu button text and added createConfigKeyboard method
EditTransactionFlowHandler.java	Enhanced error handling for invalid fields and business rule violations
SelectWalletCallbackHandler.java	Removed currency symbol from balance display for consistency
ConfigCallbackHandler.java	New handler for configuration menu displaying login and delete user options
EditTransactionFieldCallbackHandler.java	Fixed date format prompt from DD/MM/AAAA to DD/MM/YYYY
EditTransactionCallbackHandler.java	Replaced assertion with proper null check and exception
DeleteTransactionCallbackHandler.java	Improved error message clarity
BotAction.java	Added CONFIG, CONFIRM_DELETE_USER, and DELETE_USER actions
UpdateWalletService.java	Added duplicate name validation and database integrity violation handling
FindWalletByUserIdService.java	Added user existence validation before fetching wallets
CreateWalletService.java	Refactored to use constructor injection for maximum wallet limit
UserRepositoryPort.java	Added existsById method declaration
maven.yml	Enhanced CI workflow to capture and display test summaries

Comments suppressed due to low confidence (1)

.github/workflows/maven.yml:44

• There are two steps with the same name "Add Test Summary" that perform similar but slightly different actions. The first step (lines 32-36) does not handle the case where grep fails, while the second step (lines 38-44) does. This duplication is unnecessary and can cause confusion. Consider consolidating these into a single step that includes proper error handling.

      - name: Add Test Summary
        if: always()
        run: |
          echo "## 🧪 Resultado dos Testes" >> $GITHUB_STEP_SUMMARY
          echo "" >> $GITHUB_STEP_SUMMARY
          grep "Tests run:" test-output.txt >> $GITHUB_STEP_SUMMARY || echo "Nenhum resumo encontrado." >> $GITHUB_STEP_SUMMARY
          echo "" >> $GITHUB_STEP_SUMMARY

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The test is missing verifyNoMoreInteractions call at the end, which is inconsistent with the pattern used in other test methods in this file. For consistency and to ensure no unexpected interactions occur, add verifyNoMoreInteractions(findWalletByIdUseCase, walletRepositoryPort) after line 146.

Suggested change

	verifyNoMoreInteractions(findWalletByIdUseCase, walletRepositoryPort);

[Copilot]

The test is missing verifyNoMoreInteractions call and does not verify all expected interactions. The test should verify that userRepositoryPort.findById, walletRepositoryPort.countByUserId, and walletRepositoryPort.existsByUserIdAndName were called, then add verifyNoMoreInteractions(userRepositoryPort, walletRepositoryPort) to ensure no unexpected interactions occurred.

Suggested change

	verify(walletRepositoryPort).save(any(Wallet.class));
	verify(userRepositoryPort).findById(user.getId());
	verify(walletRepositoryPort).countByUserId(user.getId());
	verify(walletRepositoryPort).existsByUserIdAndName(user.getId(), wallet.getName());
	verify(walletRepositoryPort).save(any(Wallet.class));
	verifyNoMoreInteractions(userRepositoryPort, walletRepositoryPort);

[Copilot]

There is a grammatical error in the test description. "do forma" should be "de forma".

Suggested change

	@DisplayName("Deve mostrar o saldo da carteira do usuário do forma correta")
	@DisplayName("Deve mostrar o saldo da carteira do usuário de forma correta")

[Copilot]

The test is missing verifyNoMoreInteractions call at the end, which is inconsistent with the pattern used in other test methods in this file. For consistency and to ensure no unexpected interactions occur, add verifyNoMoreInteractions(findWalletByIdUseCase, walletRepositoryPort) after line 131.

Suggested change

	verify(walletRepositoryPort).save(existingWallet);
	verify(walletRepositoryPort).save(existingWallet);
	verifyNoMoreInteractions(findWalletByIdUseCase, walletRepositoryPort);

[Copilot]

The test-output.txt file is created in the zaldo-api directory (due to working-directory being set), but the subsequent steps that reference it don't specify a working directory. This means they will look for test-output.txt in the root directory, not in zaldo-api/, which will cause the grep command to fail. Either add working-directory: zaldo-api to the test summary steps or adjust the path to zaldo-api/test-output.txt.

Suggested change

	if: always()
	if: always()
	working-directory: zaldo-api