Conversation
Co-authored-by: WilleLX1 <68472201+WilleLX1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failure in StateDedupTest for last_preview
fix: preserve ConversationMeta.last_preview through serialization round-trip
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ConversationMeta JSON deserialization so last_preview survives a serialization round-trip (unblocking StateDedupTest.ConversationMetaRoundTrip and keeping state I/O symmetric with to_json).
Changes:
- Remove
from_json(ConversationMeta&)logic that replaced any non-emptylast_previewwith"(encrypted message)". - Deserialize
last_previewdirectly viaj.value("last_preview", "").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: WilleLX1 <68472201+WilleLX1@users.noreply.github.com>
Contributor
Author
Applied in commit 24f7467. |
Copilot
AI
changed the title
fix: preserve ConversationMeta.last_preview through serialization round-trip
fix: mask ConversationMeta.last_preview on deserialization to prevent plaintext exposure
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_jsonforConversationMetawas unconditionally replacing any non-emptylast_previewwith the literal"(encrypted message)", causingStateDedupTest.ConversationMetaRoundTripto fail. Based on review feedback, the correct fix is to preserve the masking behavior for privacy — preventing any sensitive plaintext previews from being resurfaced out of persisted state — but using a consistent masked value.Change
Updated
from_jsonforConversationMetato always setlast_previewto"[encrypted message]"regardless of the stored value, and updatedStateDedupTest.ConversationMetaRoundTripto expect this masked value after a round-trip:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.