Skip to content

Add optional depenency on hdf5plugin#43

Merged
WillJRoper merged 9 commits intoWillJRoper:mainfrom
smsutherland:hdf5plugin
Nov 13, 2025
Merged

Add optional depenency on hdf5plugin#43
WillJRoper merged 9 commits intoWillJRoper:mainfrom
smsutherland:hdf5plugin

Conversation

@smsutherland
Copy link

Sometimes hdf5 compression plugins are in a non-standard directory which h5py can't find. In these cases it's useful to use hdf5plugin to ensure h5py is always able to open datasets with non-standard compression.
This PR adds an optional dependency on hdf5plugin for use in these situations.

smsutherland added 3 commits November 13, 2025 14:13
Allows h5forest to work in environments with a non-standard hdf5 plugin directory.
"Cannot open dataset, try `pip install h5forest[hdf5plugin]`"
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (724ac50) to head (c92de8f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2494      2517   +23     
=========================================
+ Hits          2494      2517   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@WillJRoper WillJRoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

Main complaint by the CI workflows is that this causes a drop in unit test coverage. The new decortator needs some units tests added. By all means, use an AI assistant for them.

@WillJRoper WillJRoper added the bug Something isn't working label Nov 13, 2025
@smsutherland
Copy link
Author

Also I just realized it might be worth it to check if hdf5plugin is installed, and only change the message if it isn't. If an OSError comes up while hdf5plugin is installed, it should go right through.

@WillJRoper
Copy link
Owner

Also I just realized it might be worth it to check if hdf5plugin is installed, and only change the message if it isn't. If an OSError comes up while hdf5plugin is installed, it should go right through.

Definitely, I did worry that it's going to catch a whole host of errors (though many will have triggered earlier than this).

@WillJRoper WillJRoper merged commit 69721cd into WillJRoper:main Nov 13, 2025
33 of 34 checks passed
WillJRoper added a commit that referenced this pull request Feb 9, 2026
Add optional depenency on hdf5plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants