Add optional depenency on hdf5plugin#43
Conversation
Allows h5forest to work in environments with a non-standard hdf5 plugin directory.
"Cannot open dataset, try `pip install h5forest[hdf5plugin]`"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2494 2517 +23
=========================================
+ Hits 2494 2517 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillJRoper
left a comment
There was a problem hiding this comment.
Some minor comments.
Main complaint by the CI workflows is that this causes a drop in unit test coverage. The new decortator needs some units tests added. By all means, use an AI assistant for them.
|
Also I just realized it might be worth it to check if hdf5plugin is installed, and only change the message if it isn't. If an OSError comes up while hdf5plugin is installed, it should go right through. |
Definitely, I did worry that it's going to catch a whole host of errors (though many will have triggered earlier than this). |
Add optional depenency on hdf5plugin
Sometimes hdf5 compression plugins are in a non-standard directory which h5py can't find. In these cases it's useful to use hdf5plugin to ensure h5py is always able to open datasets with non-standard compression.
This PR adds an optional dependency on hdf5plugin for use in these situations.