Backfill missing Wall Street Journal aggregate data #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix existing model object check to use the .first() method instead of slicing. Bug: T404879 Change-Id: I97bbfc55162194bc970c664995b0ec8184405e10
suecarmol
approved these changes
Oct 3, 2025
Contributor
suecarmol
left a comment
suecarmol
left a comment
There was a problem hiding this comment.
I can confirm I see data from uploading a couple of days in December 2024, including the WSj.com collections and MarketWatch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T404879
Change-Id: I97bbfc55162194bc970c664995b0ec8184405e10
Description
Describe your changes in detail following the commit message guidelines
This fixes the warning we saw in production where the QuerySet has no attribute save.
Rationale
Phabricator Ticket
https://phabricator.wikimedia.org/T404879
How Has This Been Tested?
Re-ran the command locally using December 2024 archives and saw that the warning was no longer there.
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: