Better error managment and implemented kokoro tts#101
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:comment-wrapping reported by reviewdog 🐶
A block comment may not be followed by any other element on that same line
🚫 [ktlint] standard:comment-wrapping reported by reviewdog 🐶
A block comment may not be followed by any other element on that same line
🚫 [ktlint] standard:comment-wrapping reported by reviewdog 🐶
A block comment may not be followed by any other element on that same line
🚫 [ktlint] standard:comment-wrapping reported by reviewdog 🐶
A block comment may not be followed by any other element on that same line
🚫 [ktlint] standard:final-newline reported by reviewdog 🐶
File must end with a newline (\n)
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
src/main/kotlin/services/lavaplayer/manager/KokoroAudioTrack.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/services/lavaplayer/manager/KokoroSourceManager.kt
Outdated
Show resolved
Hide resolved
Wikijito7
force-pushed
the
feature/95-make-a-better-error-managment
branch
from
1076f7b to
847896d
Compare
|
| "country_code": "ES", | ||
| "token": "" | ||
| }, | ||
| "kokoro": { |
There was a problem hiding this comment.
I'd add an option to enable or disable this, as not all people will have an instance of Kokoro running when using the bot
| "default_voice": "", | ||
| "default_speed": 1.0, | ||
| "default_lang_code": "" |
There was a problem hiding this comment.
This is a template, so add good defaults:
| "default_voice": "", | |
| "default_speed": 1.0, | |
| "default_lang_code": "" | |
| "default_voice": "am_santa", | |
| "default_speed": 1.0, | |
| "default_lang_code": "en" |
| "remote_cipher_url": null, | ||
| "remote_cipher_password": null | ||
| }, | ||
| "hugging_chat": { |
There was a problem hiding this comment.
While you are at it, also remove these unused config parameters
2 participants
Solves #95.
📋 Changelist Summary
Better error managment and implemented kokoro tts
💬 Description
Implemented better error managment for Command and Lavaplayer/API usages. Now, we will throw the exception and it will be catched at the new
ErrorHandlerService.Also, implemented kokoro and changed tts command to use it instead of FloweryTTS, which has been removed from the bot.