Skip to content

Check Qt6 support flag#57

Merged
kannes merged 5 commits intomainfrom
qt6_compatible
Apr 3, 2025
Merged

Check Qt6 support flag#57
kannes merged 5 commits intomainfrom
qt6_compatible

Conversation

@kannes
Copy link
Copy Markdown
Contributor

@kannes kannes commented Mar 31, 2025 •
edited
Loading

According to qt5_to_qt6.py there was nothing left to do.

Let's just see what happens.

Fixes #39

@kannes kannes requested a review from Guts March 31, 2025 11:55
@kannes kannes mentioned this pull request Mar 31, 2025
Closed
@Guts
Copy link
Copy Markdown
Collaborator

Guts commented Mar 31, 2025

I've been working on Qt5/6 compatibility lately. I've published GitLab CI snippet on QGIS wiki and I'm about to achieve a piece of GitHub Actions: https://github.com/geotribu/qtribu/pull/208/files

What do you think? It could fit this project and PR no?

@kannes
Copy link
Copy Markdown
Contributor Author

kannes commented Mar 31, 2025

Oh nice, that looks useful. If you are willing to integrate that, I'd love it!

@kannes
Copy link
Copy Markdown
Contributor Author

kannes commented Apr 3, 2025

Let's keep that in a separate PR so that I can merge this one and do the 0.7.0 release today or tomorrow. Ok with you?

@github-actions github-actions bot added the ci-cd Intégration et déploiement continus (GitHub Action, Workflow) label Apr 3, 2025
@Guts
Copy link
Copy Markdown
Collaborator

Guts commented Apr 3, 2025

ups sorry @kannes I was working locally and I missed your latest comment :/. Would you prefer that I cherry pick my latest commit to another branch?

@Guts Guts requested a review from jmkerloch April 3, 2025 08:45
@Guts
Copy link
Copy Markdown
Collaborator

Guts commented Apr 3, 2025 •
edited
Loading

Well as I contributed also to this PR, I let you review/approve @jmkerloch

jmkerloch
jmkerloch approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kannes
Copy link
Copy Markdown
Contributor Author

kannes commented Apr 3, 2025

Excellent, thanks!

Then I will do the non-experimental 0.7.0 this afternoon, woohoo!

@kannes kannes merged commit 0737ea0 into main Apr 3, 2025
6 checks passed
@Guts Guts deleted the qt6_compatible branch April 3, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmkerloch jmkerloch jmkerloch approved these changes

@Guts Guts Awaiting requested review from Guts

Assignees

No one assigned

Labels

ci-cd Intégration et déploiement continus (GitHub Action, Workflow)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add PyQt6 support

4 participants

@kannes @Guts @jmkerloch @jk-wg