Skip to content

Take lat long#39

Open
Diana20920 wants to merge 4 commits intomainfrom
take-lat-long
Open

Take lat long#39
Diana20920 wants to merge 4 commits intomainfrom
take-lat-long

Conversation

@Diana20920
Copy link
Contributor

Pull Request

🚨🤦🏽🚨 Problem:

We want to be able to take in a latitude and longitude in addition to a zip code

🌟💡🌟 Solution:

  • Created a happy path test
  • Changed our #valid? method so it can account for latitude and longitude being sent in the zip params

🤔💬🤔 Test plan:

  1. The happy path test passes
  2. I currently have the sad path test skipped: zip must be a string of 5 numbers
  3. Once this works with FE, I want to change the zip word used to account for lat and long (maybe location)

👁‍👁‍ Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring

💠✅💠 CheckList:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

💯🦥💯 Test Coverage: 97.16%

@Diana20920 Diana20920 self-assigned this Oct 1, 2021
@Diana20920 Diana20920 added BE Complete in BE repo documentation Improvements or additions to documentation enhancement New feature or request labels Oct 1, 2021
@Diana20920 Diana20920 requested a review from Patfindley October 18, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BE Complete in BE repo documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant