Saved Tones, Multi Tone Paging, UI Redesign

[DeathSoulYTDev]

• Added Support For Multi Tone Paging

[DeathSoulYTDev]

i have Updated the the code and removed all unneeded code that was commented out i have also fixed the UI Bug with tabs

[DeathSoulYTDev]

This has also been tested with the fivem script and I have confirmed that it works

[Firav]

@firealarmss My suggestion would be to close this PR and #7.
@DeathSoulYTDev We need separate PR's made for the changed you're making. The changes outlined in this PR are not just adding support for multi-tone paging, but also large overhauls to the Console UI itself. Please either isolate the changes into different PR's or open a new PR with all changes listed so that we can properly review the changes you're proposing without having to cross-reference your #7 as well. It also seems like there were some changes requested in #7 were not addressed in this PR as well.

[DeathSoulYTDev]

@firealarmss My suggestion would be to close this PR and #7. @DeathSoulYTDev We need separate PR's made for the changed you're making. The changes outlined in this PR are not just adding support for multi-tone paging, but also large overhauls to the Console UI itself. Please either isolate the changes into different PR's or open a new PR with all changes listed so that we can properly review the changes you're proposing without having to cross-reference your #7 as well. It also seems like there were some changes requested in #7 were not addressed in this PR as well.

everything from 7 should be in this PR and as for changes on 7 what where those changes not addressed? as i do remember fixing it all

[DeathSoulYTDev]

i can also rename this PR and add a list of what was changed & addedd

[DeathSoulYTDev]

PR Changes

• Added Support for Saving QC2 Tones
• Added Channel Sorting VIA Zone/Department Tabs,
• Filtered QC2 Tones Through Zone/Department Tabs to sit in same Tab and the Corresponding Channel
• Made QC2 Tone Boxes Draggable Along with Channel Boxes
• Redesigned The Console's Whole UI into a Dark Theme

Thats what was added & changed

[Firav]

@firealarmss My suggestion would be to close this PR and #7. @DeathSoulYTDev We need separate PR's made for the changed you're making. The changes outlined in this PR are not just adding support for multi-tone paging, but also large overhauls to the Console UI itself. Please either isolate the changes into different PR's or open a new PR with all changes listed so that we can properly review the changes you're proposing without having to cross-reference your #7 as well. It also seems like there were some changes requested in #7 were not addressed in this PR as well.

everything from 7 should be in this PR and as for changes on 7 what where those changes not addressed? as i do remember fixing it all

If thats the case, when using this PR as snapshot and attempting to load a codeplug with the tones: array results in a parsing error and crash. Works fine with the branch #7 is based on, just not this one.

@firealarmss Is there a reason we couldn't just reuse the AlertTone box for this? That would allow us to keep all the same logic. You could use a property in the class to tell it if it is a tone box or not.

This was never addressed, you are still using new objects, not the AlertTone box.

[DeathSoulYTDev]

If thats the case, when using this PR as snapshot and attempting to load a codeplug with the tones: array results in a parsing error and crash. Works fine with the branch #7 is based on, just not this one.

Fixed

@firealarmss Is there a reason we couldn't just reuse the AlertTone box for this? That would allow us to keep all the same logic. You could use a property in the class to tell it if it is a tone box or not.
This was never addressed, you are still using new objects, not the AlertTone box.

was not able to find a way to make that work without major rewriting of the component and massive code base issues along side unreadable code so i had to stick with making it its own component

[Firav]

@DeathSoulYTDev was not able to fix a way to make that work with major rewriting of the component and mass code base issues along side unreadable code so i had to stick with making it its own component

@firealarmss back to you on this one in reference to your requested changes in #7