Fix potential issues when the 'enforce_ceager' mode is set to 'False' #72#73
Open
LeeWant wants to merge 2 commits intoWenyueh:mainfrom
Open
Fix potential issues when the 'enforce_ceager' mode is set to 'False' #72#73LeeWant wants to merge 2 commits intoWenyueh:mainfrom
LeeWant wants to merge 2 commits intoWenyueh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issues include the following:
slot_mappingwas originally mapped at block granularity, whileinput_idsoperate at token granularity. As a result, when a block is not fully occupied,slot_mappingignores the unfilled block and proceeds starting from the next new block.max_num_seqsis inconsistent with the setting in the config; the model's finaloutputis theoutputwithout Softmax, not the logits.