Open
Conversation
Author
|
@WenjianBI Would it be possible to merge in the fixes I've proposed in this PR? SPACox is very useful for our work, but the bug with 100% missingness has thrown a bit of a wrench in things for us. |
dvg-p4
commented
Jul 24, 2024
Comment on lines
+248
to
+251
| if(missing.rate == 1){ | ||
| return(c(NA, 1, NA, NA, NA, NA, NA)) | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
This portion is the actual fix for the missingness bug--the rest is all cleanup of documentation and imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
I also took the liberty of making some minor fixes to the documentation, mainly adding a line for the
G.modelargument, and using@inheritParamsto automatically reuse the parameter documentation fromSPACox()forSPACox.plink()andSPACox.one.SNP(). I addressed most of the other warnings and notes from R CMD check as well.TODO: