fix(ci): add workflow_dispatch to publish and remove [skip ci] from auto-bump#16
fix(ci): add workflow_dispatch to publish and remove [skip ci] from auto-bump#16WellDunDun merged 2 commits intomasterfrom
Conversation
…uto-bump The [skip ci] tag in auto-bump commit messages propagates into squash merge commits, causing the Publish workflow to be skipped on merge. Remove [skip ci] from the auto-bump message and add workflow_dispatch to publish.yml for manual re-runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates two GitHub Actions workflows: it removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/publish.yml:
- Around line 3-6: The publish workflow currently allows manual dispatch on any
branch; add a guard to the publish job so it only runs for master when manually
triggered—modify the publish job configuration (the job named "publish" in the
workflow) to include an if condition that verifies the run ref is master (e.g.
check github.ref == 'refs/heads/master' or github.ref_name == 'master') before
executing steps, and ensure any dependent steps or job-level permissions still
run only when that condition passes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 15202e35-587e-4899-abe5-c4849e9f03da
📒 Files selected for processing (2)
.github/workflows/auto-bump-cli-version.yml.github/workflows/publish.yml
Guard against accidental releases from non-master branches when using workflow_dispatch manual trigger. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
workflow_dispatchtopublish.ymlso we can manually trigger publishes when needed[skip ci]from the auto-bump commit message — this tag was propagating into squash merge commit bodies, causing GitHub Actions to skip all workflows (including Publish) on merge to masterThis is why PR #15's merge didn't trigger a publish: the squashed body contained
chore: bump cli version to v0.1.4 [skip ci].Test plan
reins-cli@0.1.4appears on npm after publishworkflow_dispatchbutton appears on the Publish workflow page🤖 Generated with Claude Code
Summary by CodeRabbit