β‘ Optimize game state serialization for broadcasts #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
Game.get_view_for_playerandGameService.get_player_viewto accept an optionalfull_schemaargument.broadcast_filtered_statesinbackend/app/api/routers/rooms.pyto generate the full game schema once and pass it to the view generation function for each player.π― Why:
get_view_for_playercalledself.to_schema()internally every time.π Measured Improvement:
get_view_for_player.PR created automatically by Jules for task 15313983742005791179 started by @WeixuanZ