β‘ Optimize Redis usage in player view broadcast #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
Optimized
get_player_viewandbroadcast_filtered_statesto batch presence checks.get_all_player_presencemethod toGameServiceto fetch presence for all players in one go.get_player_viewto accept an optionalpresence_map.broadcast_filtered_statesinbackend/app/api/routers/rooms.pyto fetch presence once and pass it down.π― Why:
Previously, broadcasting game state to N players resulted in N separate calls to
get_player_view, each triggering a Redismgetfor presence. This caused N round-trips to Redis.With this change, presence for all players is fetched once per broadcast, reducing Redis calls from N (per connected player) to 1.
π Measured Improvement:
Benchmark with N=50 players:
PR created automatically by Jules for task 8902105928956179380 started by @WeixuanZ