-
Notifications
You must be signed in to change notification settings - Fork 43
Adding type hints for other End files delegating.py, grouping.py, ipexing.py, notifying.py, exchanging.py #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…uping.py, ipexing.py, notifying.py, exchanging.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 1 1
Lines 324 324
Branches 24 24
=======================================
Hits 316 316
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| sigs: string[], | ||
| recp: string[] | ||
| ): Promise<any> { | ||
| ): Promise<Operation<unknown>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lenkan We have a follow up PR (in progress, almost there) that converts these to specific WitnessOperation, GroupOperation etc... (not generics) so should cleanup some of the things from this PR.
test-integration/credentials.test.ts
Outdated
|
|
||
| assert.strictEqual(offer.exn.p, applySaid); | ||
| assert( | ||
| 'e' in offer.exn && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lenkan Hmm, I feel like this will become annoying. We could just use any instead of unknown in these scenarios, or alternatively offer a bunch of type guard functions but that list could grow quite large and hard to maintain. Thoughts?
|
@iFergal feel free to approve and merge. |
|
@kentbull Going to see if there's a nice way to serialise the exn resources from @Sotatek-Patrick-Vu Maybe we should mark as draft for a little while |
No description provided.