Skip to content

Conversation

@Sotatek-Patrick-Vu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.53%. Comparing base (5e540e7) to head (a281149).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files           1        1           
  Lines         324      324           
  Branches       24       24           
=======================================
  Hits          316      316           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sigs: string[],
recp: string[]
): Promise<any> {
): Promise<Operation<unknown>> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenkan We have a follow up PR (in progress, almost there) that converts these to specific WitnessOperation, GroupOperation etc... (not generics) so should cleanup some of the things from this PR.


assert.strictEqual(offer.exn.p, applySaid);
assert(
'e' in offer.exn &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenkan Hmm, I feel like this will become annoying. We could just use any instead of unknown in these scenarios, or alternatively offer a bunch of type guard functions but that list could grow quite large and hard to maintain. Thoughts?

@iFergal iFergal requested review from kentbull and lenkan December 18, 2025 17:02
@kentbull
Copy link
Collaborator

@iFergal feel free to approve and merge.

@iFergal
Copy link
Collaborator

iFergal commented Jan 14, 2026

@kentbull Going to see if there's a nice way to serialise the exn resources from exchanges().get and infer types based on the route. Because currently embeds are unknown and it's difficult to work with. You need to cast everything, so Signify should at the very least provide those.

@Sotatek-Patrick-Vu Maybe we should mark as draft for a little while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants