Skip to content

Conversation

@da-tychinin
Copy link

Issue: #230

  • moved all signature input generation from authing to httping
  • added optional authority parameter for authing methods.
  • removed Signer calls from httping. Moved them to the upper level - authing
  • refactor siginput and desiginput method to make them reflect one another
  • desiginput return value changed to map by signature label. According to the RFC the labels must be unique
  • added sigbase method to httping. It is now used in both sign and verify authing functions
  • authing.test.ts: mock httping methods.
  • added RFC test cases

* added optional authority parameter for authing methods.
* removed Signer calls from httping. moved them to the upper level (authing)
* refactor siginput and desiginput method to make them reflect each other
* desiginput return value changed to map by signature label. According to the RFC the labels must be unique
* added sigbase method to httping. It is now used in both sign and verify authing functions
* authing.test.ts: mock httping methods.
* added RFC test cases
@da-tychinin
Copy link
Author

I've fixed the error TS5097 for "build, lint and test" stages. Should work fine now. Integration test will fail because of the different signature-base serialization

@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (e2b2f6e) to head (4bd7b7d).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/keri/core/httping.ts 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   82.86%   82.89%   +0.03%     
==========================================
  Files          46       46              
  Lines        4190     4157      -33     
  Branches     1044     1034      -10     
==========================================
- Hits         3472     3446      -26     
+ Misses        689      682       -7     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan changed the base branch from development to main April 12, 2024 19:58
@lenkan lenkan added the stale Stale issues or PRs label Oct 17, 2024
@kentbull
Copy link
Collaborator

kentbull commented Oct 9, 2025

Looks like we'll need to close this PR soon. There's some good work here though it needs to be reworked with the latest Signify version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale issues or PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants