Skip to content

Conversation

@daidoji
Copy link
Collaborator

@daidoji daidoji commented Jan 31, 2024

Rationale

Not really sure why these didn't show up in my old env but in my new env got deprecation warnings about map.remove being deprecated and to use swap or shift remove to be explicit about behavior.

Switched to something that seemed to fit with old code and tests still pass.

Testing

Tests remain same, no change to behavior.

For Reviewers

  • Verify version bumped in Cargo.toml

@codecov
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cd5453) 95.42% compared to head (70645e2) 95.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          32       32           
  Lines        3037     3037           
=======================================
  Hits         2898     2898           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants