Skip to content

fix: rm Promise usage, fix tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OlehSych wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: rm Promise usage, fix tests #3

OlehSych wants to merge 1 commit into from

Conversation

@OlehSych
Copy link

@OlehSych OlehSych commented May 15, 2022

No description provided.

@OlehSych
Copy link
Author

OlehSych commented May 15, 2022 •
edited
Loading

Hey, man! I want to bring a few fixes in your code)
Feel free to change my PR (e.g. remove the custom "it" function)

officialbidisha
officialbidisha approved these changes May 18, 2024
View reviewed changes
Copy link

@officialbidisha officialbidisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thing in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@officialbidisha officialbidisha officialbidisha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OlehSych @officialbidisha