ref(*)!: Reorganizes the blobstore interface#23
Open
thomastaylor312 wants to merge 1 commit intoWebAssembly:mainfrom
Open
ref(*)!: Reorganizes the blobstore interface#23thomastaylor312 wants to merge 1 commit intoWebAssembly:mainfrom
thomastaylor312 wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
This is a relatively simple PR that mostly restructures things. This removes the container interface because there wasn't much you could do with it by itself, it always had to be used in conjunction with the blobstore interface. I also got rid of all of the type aliases for strings to make the types interface cleaner, as well as follow what we've been doing in the other wasi cloud interfaces with avoiding type aliases. Additionally, I updated the timestamps to use the wasi-clock timestamps instead so we were using a concrete type. That was the only major change here, but it does solve an outstanding issue we have. Closes WebAssembly#7 Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
Mossaka
reviewed
Jul 29, 2024
|
|
||
| // creates a new empty container | ||
| create-container: func(name: container-name) -> result<container, error>; | ||
| create-container: func(name: string) -> result<container, string>; |
Collaborator
There was a problem hiding this comment.
perhaps we want an enum type for the error of blob store operations?
Collaborator
Author
There was a problem hiding this comment.
I thought about that, but didn't want to do too many changes here. I can open an issue and address in a follow up along with #5. Might also do as a separate commit to this PR if needed
|
@thomastaylor312, with the proposed update, how either of the following # blobstore.wit
copy-object: func(src: string, dest: string) -> result<_, string>;
move-object: func(src: string, dest: string) -> result<_, string>;Before the update # types.wit
// identifier for an object that includes its container name
record object-id {
container: container-name,
object: object-name
}So it had a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively simple PR that mostly restructures things. This removes the container interface because there wasn't much you could do with it by itself, it always had to be used in conjunction with the blobstore interface. I also got rid of all of the type aliases for strings to make the types interface cleaner, as well as follow what we've been doing in the other wasi cloud interfaces with avoiding type aliases.
Additionally, I updated the timestamps to use the wasi-clock timestamps instead so we were using a concrete type. That was the only major change here, but it does solve an outstanding issue we have.
Closes #7