Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Code Review

Siravich Termvadsayanon edited this page Nov 9, 2022 · 10 revisions

Procedure

Purpose
  • To check that the code is working correctly
  • To check that code not redundant
  • To improve code coverage
Preconditions
  • Completed and reviewed program
  • Code review checklist
  • Everyone in group understand the code
Steps Activities Description
1 Preparation
  • Team members discuss the agenda of the meeting, and the current condition of the work product.
2 Review
  • Each team member discusses the issues they encountered during the code review. The author either agrees or rejects the position. If the author doesn't agree, they must explain the reason, otherwise the problem will be resolved in the rework process.
3 Correct & Rework
  • Each team member will comment on suggested solutions for the problem.
4. Follow-up
  • Group members will check that the solutions are acceptable.
  • All identified issues by fix & rework will be more reviewed.
Postconditions
  • complete review of the code
  • Every bugs in the code has resolve
  • Review of code review checklists

Code Checklist

  • Code format

    [ ] Naming convention ( camel case )

    [ ] Docstring

    [ ] Indentation ( follow PEP8 by pylint )

  • Test quality

    [ ] code coverage above 80%

    [ ] URL link correctly

    [ ] All url links to the right page?

  • Class and Function

    [ ] Error and exception handling

  • Security

    [ ] User authentication

    [ ] Externalize configuration

Summary

This code review is used for detecting bugs, checking redundant code ,and code format for more readability and understanding.

Issues

  • Issues#67 Payment status doesn't update.
  • Issues#68 Headers can pay him/herself.
  • Issues#69 When the bill is not created(initial) the bill appears on the bill page.
  • Issues#70 When randomly type url it will be 404 error instead of redirect to bill page.

Clone this wiki locally