panel : menu : fix label ; fix extra actions for grid view ; added css sizing/styling ; reduced search jank#358
panel : menu : fix label ; fix extra actions for grid view ; added css sizing/styling ; reduced search jank#358AKArien wants to merge 13 commits intoWayfireWM:masterfrom
Conversation
|
@trigg you’ll have to tell me if you too prefer this set of bugs ;) |
I'm not certain max-character-width should be zero |
|
All the context-menu options are inactive in this PR. |
|
Left clicking an arrow in list-mode runs the default action and doesn't show the context menu |
|
Switching from list mode and back leaves the layout confused |
Honestly, i’m not so certain anymore i understand how the size requests work, as it seems ellipsising works fine in list mode. However, the way things currently are at least, i couldn’t get it to work properly with the flowbox as grid. It was fine-ish before because the size of the icons was hard-coded, but if it’s changeable, ellipsizing needs to work like as per this pr.
hu, i could have sworn i had fixed that… |
This reverts commit d200535.
|
Looking much cleaner now! I'll give it another read through but I'm not seeing any breakage right now |
keep looking, it’s never far ;) |
| extra_actions_button.activate(); | ||
| long_press_g->set_state(Gtk::EventSequenceState::CLAIMED); | ||
| left_click_g->set_state(Gtk::EventSequenceState::DENIED); | ||
| right_click_g->set_state(Gtk::EventSequenceState::DENIED); |
There was a problem hiding this comment.
No need to deny right_click_g here as it can't have been started. I don't think there's ramifications for doing this, but it isn't necessary.
A left click gesture would have started on a touch, but not a ->set_button(3) gesture
2 participants
Extra actions were previously made unavailable for grid mode, added them back.
The label position was put always on the side instead of the bottom for grid mode, put it back below.
General cleanups of the implementation and declaration of WfMenuMenuItem, as well as renamed it to WfMenuItem.
Made menu items sizeable by css (app-button) and by a new config option.
New configuration option to set spacing between menu items.
Reduced jank on search, it now behaves like a proper text input, at the price of eating the first key when user attempts to type while it is not focused.
Addresses #325