Conversation
Contributor
Author
|
(pls run uncrustify job) |
hustlerone
force-pushed
the
master
branch
2 times, most recently
from
0fedd2b to
b1a3a22
Compare
Matches the uncrustify setup on Wayfire.
Namely, `MODE_HIGHRR` and `MODE_HIGHRES`. They change the criteria on the "best" monitor mode. This is a breaking change. mode_t now only allows enums for the AUTO mode(s).
Contributor
Author
|
Adjusted and uncrustified, CI should pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
preferredvideo mode is a nice heuristic. However, some monitors and TV's preferred mode is not up to the user's preference.This adds two modes,
AUTO_HIGHRRandAUTO_HIGHRES.The former chooses the highest refresh rate first then chooses the highest resolution that satisfies the initial constraint.
The latter just scrapes the barrel with the video modes. It chooses the "biggest" one.
I am not sure if the function
wf::output_config::mode_t::mode_tinsrc/types.cppneeds to be changed.