-
-
Notifications
You must be signed in to change notification settings - Fork 37
Feat(mockserver UI) refining the UI #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.11
Are you sure you want to change the base?
Conversation
Better DM View still looks like shit but well
I merged v0.11 into the mock-ui branch because this one branch lacked some fix.
This is a small fix in the discord js package, basically when using doppler to inject env vars, envData would not have them early enough, this ensures process.env is used as fallback
for some reasons, resolving packages was causing a lot of errors because it was not chained with optional ?
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
create-discord-activity
create-robo
@robojs/server
@robojs/better-stack
@roboplay/plugin-confessions
@robojs/dev
@roboplay/plugin-gpt
@robojs/maintenance
@robojs/moderation
@roboplay/plugin-poll
@robojs/sync
robo.js
@roboplay/sage
@robojs/ai
@robojs/analytics
@robojs/auth
@robojs/cli
@robojs/code
@robojs/cron
@robojs/discordjs
@robojs/giveaways
@robojs/i18n
@robojs/mock
@robojs/patch
@robojs/roadmap
@robojs/trpc
@robojs/xp
commit: |
It is supposed to have fixed Windows paths issues (hopefully all) but testing needs to be done further as always
Fix plugin manifest merge when pnpm list returns no dependency paths On Windows / non-workspace installs, pnpm list <pkg> --json returns only the project header, so findPackagePath() treated plugins as “not installed.” This prevented plugin manifests (like @robojs/mock) from merging into the project and broke /mock/api/* routes. Added a fallback helper that checks node_modules/<pkg> when pnpm output lacks a path, and normalize relative paths.
@Pkmmte Hey, hope you are fine <3, anyways, would you be able to quickly check this PR, I tried merging V0.11 to be up to date because it contains fix needed on Windows that werent on the branch, but now I got int oan issue, the mock server refuses to connect with discord.js,
Also please look at the discordjs package and how it fetches env as you know I am using doppler and the current solution was not working, so I added fallbacks, which worked but I d like to know if it is fine :3